feat(cli): hard-fail backup/apply on unsupported Spotify versions#3894
Closed
afonsojramos wants to merge 1 commit into
Closed
feat(cli): hard-fail backup/apply on unsupported Spotify versions#3894afonsojramos wants to merge 1 commit into
afonsojramos wants to merge 1 commit into
Conversation
Ship a support list and refuse to mutate Spotify when the installed client is outside the known window, with explicit override escapes.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supported-versions.json(seed allowlist: Spotify 1.2.86–1.2.93) shipped with releasesbackup,apply, andautoso unknown Spotify versions fail closed with a clear message--force-unsupported-spotifyandspotify_version_check=01.2.93.x…→1.2.93) and encode classmap keys for later phasesWhy
Spicetify currently fails late (regex mismatch) on new Spotify builds. This is the first step toward only applying to known versions, with the support list as the source of truth.
Overrides
--force-unsupported-spotifyspotify_version_check=0restore/clear/ config commands stay ungated so recovery always works.Test plan
go test ./src/utils/go buildspicetify backupproceeds past the gatebackup/applyexit 1 with support summary--force-unsupported-spotifycontinues after a warningspicetify config spotify_version_check 0then backup continues after a warningrestorestill works when version is unsupportedsupported-versions.json(build.yml)