Error on duplicate and colliding command registrations - #251
Open
johncarmack1984 wants to merge 1 commit into
Open
johncarmack1984 wants to merge 1 commit into
johncarmack1984 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115.
What changed
function_casingis applied (e.g.my_cmdandmyCmdboth exporting asmyCmd), with a message that names both commands and the colliding accessorWhy
commands.myCmdsilently binding to whichever registration came last is a correctness trap — the error surfaces it at export time with the exact names involved.Notes
Two same-named commands in different modules of one crate currently can't even be constructed — the generated
__specta__fn__*/__cmd__*helper macros collide at crate root (the same family as #142) — so that scenario is only reachable across crates (e.g. a plugin command clashing with an app one), where this check still catches it. Noted in the test file.Validation
cargo test --all-features(3 new tests)cargo clippy --all-features --all-targets(no warnings)cargo fmt --check