Repository navigation
Convert palette images to truecolor before encoding avif with gd - #333
Merged
freekmurze merged 2 commits intoSep 30, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thanks @AlexisSerneels! Great catch on the PNG-8 to AVIF failure with GD, and nice that the fix came with regression tests for both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GD driver fails to save palette (indexed color) images as AVIF:
This shows up in practice with PNG-8 images (common output of PNG optimizers). With spatie/laravel-medialibrary, any AVIF conversion of such an upload fails, so the conversion is never generated.
The WebP branch already handles this by calling
imagepalettetotruecolor()beforeimagewebp(), but the AVIF branch does not.Fix
Call
imagepalettetotruecolor()beforeimageavif(), in bothsave()andbase64(), mirroring the WebP handling.Tests
Added two tests using the existing
palette-webp.pngfixture: saving to AVIF and encoding to AVIF base64. Both are skipped when AVIF is not supported, like the existing AVIF tests.Ran with PHP 8.4 and GD built with libavif: both GD tests fail without the fix and pass with it.