Tighten fast-mode additionalProperties and required elision preconditions#930
Merged
Conversation
…nditions Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR tightens the conditions under which the fast-mode compiler elides object-keyword checks for Changes:
Technical Notes: The core theme is making fast-mode elision decisions depend on schema intent (boolean 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| // A non-empty `required` rejects a non-object on its own, so the type | ||
| // assertion is redundant. An empty `required` asserts nothing, so the | ||
| // type check must stay | ||
| if (context.mode == Mode::FastValidation && |
There was a problem hiding this comment.
This changes fast-mode behavior for draft-06 too; consider adding a type: object + required: [] evaluator case to test/evaluator/evaluator_draft6.json (similar to the new draft-07/2019-09/2020-12 cases) to prevent regressions.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="test/evaluator/evaluator_draft6.json">
<violation number="1" location="test/evaluator/evaluator_draft6.json:6526">
P2: Inconsistent description for `LoopPropertiesExcept` when `additionalProperties` is a non-boolean schema. The fast mode descriptions use the boolean-`false` text "The object value was not expected to define additional properties" while exhaustive mode correctly uses "The object properties not covered by other adjacent object keywords were expected to validate against this subschema". This affects 4 test cases: `pattern_properties_nonboolean_additional`, `pattern_properties_nonboolean_additional_matching`, `closed_properties_nonboolean_additional`, and `closed_properties_nonboolean_additional_known`. The descriptions should be consistent between modes since they document the same assertion.</violation>
</file>
<file name="src/compiler/default_compiler_draft3.h">
<violation number="1" location="src/compiler/default_compiler_draft3.h:2154">
P3: The `required` elision precondition was tightened here for draft-06 (empty `required` no longer suppresses the type check), but unlike draft-07/2019-09/2020-12, no corresponding `type: object` + `required: []` evaluator test was added to `test/evaluator/evaluator_draft6.json`. Adding equivalent `type_object_empty_required_null` and `type_object_empty_required_object` cases for draft-06 would guard against regressions in this specific code path.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| @@ -6350,5 +6350,331 @@ | |||
| "valid": true, | |||
There was a problem hiding this comment.
P2: Inconsistent description for LoopPropertiesExcept when additionalProperties is a non-boolean schema. The fast mode descriptions use the boolean-false text "The object value was not expected to define additional properties" while exhaustive mode correctly uses "The object properties not covered by other adjacent object keywords were expected to validate against this subschema". This affects 4 test cases: pattern_properties_nonboolean_additional, pattern_properties_nonboolean_additional_matching, closed_properties_nonboolean_additional, and closed_properties_nonboolean_additional_known. The descriptions should be consistent between modes since they document the same assertion.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At test/evaluator/evaluator_draft6.json, line 6526:
<comment>Inconsistent description for `LoopPropertiesExcept` when `additionalProperties` is a non-boolean schema. The fast mode descriptions use the boolean-`false` text "The object value was not expected to define additional properties" while exhaustive mode correctly uses "The object properties not covered by other adjacent object keywords were expected to validate against this subschema". This affects 4 test cases: `pattern_properties_nonboolean_additional`, `pattern_properties_nonboolean_additional_matching`, `closed_properties_nonboolean_additional`, and `closed_properties_nonboolean_additional_known`. The descriptions should be consistent between modes since they document the same assertion.</comment>
<file context>
@@ -6350,5 +6350,331 @@
+ "pre": [
+ [ "LoopPropertiesRegex", "/patternProperties", "#/patternProperties", "" ],
+ [ "AssertionTypeStrict", "/patternProperties/^a.$/type", "#/patternProperties/%5Ea.$/type", "/ab" ],
+ [ "LoopPropertiesExcept", "/additionalProperties", "#/additionalProperties", "" ]
+ ],
+ "post": [
</file context>
| schema_context.schema.defines("required")) { | ||
| schema_context.schema.defines("required") && | ||
| schema_context.schema.at("required").is_array() && | ||
| !schema_context.schema.at("required").empty()) { |
There was a problem hiding this comment.
P3: The required elision precondition was tightened here for draft-06 (empty required no longer suppresses the type check), but unlike draft-07/2019-09/2020-12, no corresponding type: object + required: [] evaluator test was added to test/evaluator/evaluator_draft6.json. Adding equivalent type_object_empty_required_null and type_object_empty_required_object cases for draft-06 would guard against regressions in this specific code path.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/compiler/default_compiler_draft3.h, line 2154:
<comment>The `required` elision precondition was tightened here for draft-06 (empty `required` no longer suppresses the type check), but unlike draft-07/2019-09/2020-12, no corresponding `type: object` + `required: []` evaluator test was added to `test/evaluator/evaluator_draft6.json`. Adding equivalent `type_object_empty_required_null` and `type_object_empty_required_object` cases for draft-06 would guard against regressions in this specific code path.</comment>
<file context>
@@ -2128,8 +2145,13 @@ auto compiler_draft3_validation_type(const Context &context,
- schema_context.schema.defines("required")) {
+ schema_context.schema.defines("required") &&
+ schema_context.schema.at("required").is_array() &&
+ !schema_context.schema.at("required").empty()) {
return {};
}
</file context>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (macos/llvm)
Details
| Benchmark suite | Current: 471e684 | Previous: b1d768c | Ratio |
|---|---|---|---|
Schema_Iterator_ISO_Language |
2013558.3112946595 ns/iter |
2447804.863353814 ns/iter |
0.82 |
Schema_Tracker_ISO_Language |
3177550.3582885778 ns/iter |
3851710.3774514305 ns/iter |
0.82 |
Schema_Tracker_ISO_Language_To_JSON |
16253673.46511751 ns/iter |
21246403.17646588 ns/iter |
0.77 |
Schema_Frame_WoT_References |
5024578.750000046 ns/iter |
5327427.273583745 ns/iter |
0.94 |
Schema_Frame_OMC_References |
21883388.90909053 ns/iter |
28259322.916663144 ns/iter |
0.77 |
Schema_Frame_OMC_Locations |
19764217.583334204 ns/iter |
22710452.392857406 ns/iter |
0.87 |
Schema_Frame_ISO_Language_Locations |
75412625.00000004 ns/iter |
86258546.87500124 ns/iter |
0.87 |
Schema_Frame_KrakenD_References |
41910473.05882608 ns/iter |
40531130.99999856 ns/iter |
1.03 |
Schema_Frame_KrakenD_Reachable |
619311207.9999992 ns/iter |
382813436.9998679 ns/iter |
1.62 |
Schema_Frame_ISO_Language_Locations_To_JSON |
83187629.66666782 ns/iter |
78766523.85714675 ns/iter |
1.06 |
Schema_Frame_Many_Resources_References |
284941680.33334213 ns/iter |
322723270.9999726 ns/iter |
0.88 |
Schema_Bundle_Meta_2020_12 |
1239728.3181797485 ns/iter |
1413157.7669048612 ns/iter |
0.88 |
Schema_Format_ISO_Language_To_JSON |
76691435.33334793 ns/iter |
86244527.55556275 ns/iter |
0.89 |
E2E_Compiler_adaptivecard |
50390605.7692365 ns/iter |
62739474.30769602 ns/iter |
0.80 |
E2E_Compiler_ansible_meta |
23360760.43749813 ns/iter |
26770473.214282576 ns/iter |
0.87 |
E2E_Compiler_aws_cdk |
258004.44913420442 ns/iter |
291241.1848211312 ns/iter |
0.89 |
E2E_Compiler_babelrc |
1929249.7732240532 ns/iter |
2962033.9621841284 ns/iter |
0.65 |
E2E_Compiler_clang_format |
14602810.450979883 ns/iter |
15013182.186045691 ns/iter |
0.97 |
E2E_Compiler_cmake_presets |
23705045.965518117 ns/iter |
24082254.310346328 ns/iter |
0.98 |
E2E_Compiler_code_climate |
2025040.2777776343 ns/iter |
2371654.005900084 ns/iter |
0.85 |
E2E_Compiler_cql2 |
10648813.43283709 ns/iter |
10993370.173912847 ns/iter |
0.97 |
E2E_Compiler_cspell |
19734396.454547703 ns/iter |
21734861.968752738 ns/iter |
0.91 |
E2E_Compiler_cypress |
3329551.789719385 ns/iter |
3378531.9010419813 ns/iter |
0.99 |
E2E_Compiler_deno |
6238492.584745889 ns/iter |
6575287.844037229 ns/iter |
0.95 |
E2E_Compiler_dependabot |
3204452.6787328995 ns/iter |
3891970.899470709 ns/iter |
0.82 |
E2E_Compiler_draft_04 |
1893004.2963916094 ns/iter |
2207751.4619879145 ns/iter |
0.86 |
E2E_Compiler_fabric_mod |
3378159.6231886833 ns/iter |
3991766.617485806 ns/iter |
0.85 |
E2E_Compiler_geojson |
19101073.447368313 ns/iter |
24744420.228574067 ns/iter |
0.77 |
E2E_Compiler_gitpod_configuration |
3695791.878788032 ns/iter |
4157707.991803587 ns/iter |
0.89 |
E2E_Compiler_helm_chart_lock |
553830.6871657865 ns/iter |
486319.96204289753 ns/iter |
1.14 |
E2E_Compiler_importmap |
291399.6216505989 ns/iter |
212983.98893330246 ns/iter |
1.37 |
E2E_Compiler_jasmine |
1576994.1146854253 ns/iter |
1091315.143962914 ns/iter |
1.45 |
E2E_Compiler_jshintrc |
4312053.871428492 ns/iter |
3416341.431279352 ns/iter |
1.26 |
E2E_Compiler_jsconfig |
22763544.55172372 ns/iter |
18889939.102564313 ns/iter |
1.21 |
E2E_Compiler_krakend |
174108937.49999446 ns/iter |
131938491.80001962 ns/iter |
1.32 |
E2E_Compiler_lazygit |
49663247.66666553 ns/iter |
32443824.304347955 ns/iter |
1.53 |
E2E_Compiler_lerna |
1910713.103542268 ns/iter |
1268014.7999999463 ns/iter |
1.51 |
E2E_Compiler_nest_cli |
8470077.586205913 ns/iter |
6191192.278688653 ns/iter |
1.37 |
E2E_Compiler_omc |
201627333.33332503 ns/iter |
164474604.25001737 ns/iter |
1.23 |
E2E_Compiler_omnisharp |
7139167.582417591 ns/iter |
5579810.362205106 ns/iter |
1.28 |
E2E_Compiler_openapi |
34513221.75000168 ns/iter |
20521417.882351298 ns/iter |
1.68 |
E2E_Compiler_pre_commit_hooks |
5722235.278194876 ns/iter |
4040735.7954538013 ns/iter |
1.42 |
E2E_Compiler_pulumi |
3276328.5340313874 ns/iter |
2931432.8042549645 ns/iter |
1.12 |
E2E_Compiler_semantic_release |
1243376.7552674673 ns/iter |
1168257.1458333055 ns/iter |
1.06 |
E2E_Compiler_stale |
1156678.9808307986 ns/iter |
1161778.585537992 ns/iter |
1.00 |
E2E_Compiler_stylecop |
5039761.999999869 ns/iter |
4748491.438355303 ns/iter |
1.06 |
E2E_Compiler_tmuxinator |
1461271.693609079 ns/iter |
1300916.5129633234 ns/iter |
1.12 |
E2E_Compiler_ui5 |
47765550.571422674 ns/iter |
48769500.00000591 ns/iter |
0.98 |
E2E_Compiler_ui5_manifest |
298931499.99998057 ns/iter |
293181812.5000518 ns/iter |
1.02 |
E2E_Compiler_unreal_engine_uproject |
3830543.719211921 ns/iter |
3514537.6755317464 ns/iter |
1.09 |
E2E_Compiler_users_array |
913827.5780511088 ns/iter |
675852.8834122672 ns/iter |
1.35 |
E2E_Compiler_vercel |
9952183.593750164 ns/iter |
10773378.8461526 ns/iter |
0.92 |
E2E_Compiler_yamllint |
219653.44484930197 ns/iter |
241662.89126854265 ns/iter |
0.91 |
E2E_Evaluator_adaptivecard |
17940.36767736997 ns/iter |
18858.236203094213 ns/iter |
0.95 |
E2E_Evaluator_ansible_meta |
156886.34219497326 ns/iter |
168165.92974807185 ns/iter |
0.93 |
E2E_Evaluator_aws_cdk |
34091.84463057689 ns/iter |
41701.23269554187 ns/iter |
0.82 |
E2E_Evaluator_babelrc |
77587.92851584441 ns/iter |
80805.46329173842 ns/iter |
0.96 |
E2E_Evaluator_cerebrum_criminal_case |
649651.4423077276 ns/iter |
705817.8441432125 ns/iter |
0.92 |
E2E_Evaluator_clang_format |
96322.24576270876 ns/iter |
96463.0050842971 ns/iter |
1.00 |
E2E_Evaluator_cmake_presets |
3078550.3608695846 ns/iter |
3398758.2938387548 ns/iter |
0.91 |
E2E_Evaluator_code_climate |
119381.1856601065 ns/iter |
129712.27959646517 ns/iter |
0.92 |
E2E_Evaluator_cql2 |
138278.63641518433 ns/iter |
137677.7675519449 ns/iter |
1.00 |
E2E_Evaluator_cspell |
396104.357305913 ns/iter |
431797.55089049676 ns/iter |
0.92 |
E2E_Evaluator_cypress |
130507.33402803661 ns/iter |
143490.9848165251 ns/iter |
0.91 |
E2E_Evaluator_deno |
242904.99371861518 ns/iter |
239025.21976935706 ns/iter |
1.02 |
E2E_Evaluator_dependabot |
230427.26415713454 ns/iter |
241423.57984069944 ns/iter |
0.95 |
E2E_Evaluator_draft_04 |
6829089.928057308 ns/iter |
5430394.467153401 ns/iter |
1.26 |
E2E_Evaluator_fabric_mod |
459956.37065641006 ns/iter |
553731.485049857 ns/iter |
0.83 |
E2E_Evaluator_geojson |
9663661.337209454 ns/iter |
8831420.312500883 ns/iter |
1.09 |
E2E_Evaluator_gitpod_configuration |
174949.00528466946 ns/iter |
168087.52165725146 ns/iter |
1.04 |
E2E_Evaluator_helm_chart_lock |
228918.27101075195 ns/iter |
220062.31894407698 ns/iter |
1.04 |
E2E_Evaluator_importmap |
33317.834503217055 ns/iter |
45348.63225064582 ns/iter |
0.73 |
E2E_Evaluator_jasmine |
83718.61360448667 ns/iter |
106496.24516744463 ns/iter |
0.79 |
E2E_Evaluator_jshintrc |
900382.5804455237 ns/iter |
1256788.157894861 ns/iter |
0.72 |
E2E_Evaluator_jsconfig |
300091.8790453019 ns/iter |
381737.9921656284 ns/iter |
0.79 |
E2E_Evaluator_krakend |
121743.4531249982 ns/iter |
137930.24663886972 ns/iter |
0.88 |
E2E_Evaluator_lazygit |
89677.114335316 ns/iter |
99214.08569501179 ns/iter |
0.90 |
E2E_Evaluator_lerna |
109406.18589951866 ns/iter |
138679.02380435934 ns/iter |
0.79 |
E2E_Evaluator_nest_cli |
120913.89738908505 ns/iter |
136930.94370796593 ns/iter |
0.88 |
E2E_Evaluator_omc |
12228.16372003846 ns/iter |
13137.424117082066 ns/iter |
0.93 |
E2E_Evaluator_omnisharp |
423142.67899065214 ns/iter |
464907.4235464605 ns/iter |
0.91 |
E2E_Evaluator_openapi |
4889570.101351478 ns/iter |
13777494.14912319 ns/iter |
0.35 |
E2E_Evaluator_pre_commit_hooks |
327841.6669926381 ns/iter |
433419.2335728801 ns/iter |
0.76 |
E2E_Evaluator_pulumi |
492243.7713310861 ns/iter |
780982.1048824734 ns/iter |
0.63 |
E2E_Evaluator_semantic_release |
65896.17667677475 ns/iter |
89841.18031790994 ns/iter |
0.73 |
E2E_Evaluator_stale |
110536.35173787514 ns/iter |
156333.64408148514 ns/iter |
0.71 |
E2E_Evaluator_stylecop |
177082.6107062401 ns/iter |
247021.76821187855 ns/iter |
0.72 |
E2E_Evaluator_tmuxinator |
63007.1813428746 ns/iter |
96227.08802662136 ns/iter |
0.65 |
E2E_Evaluator_ui5 |
324969.48423010693 ns/iter |
430396.8212610861 ns/iter |
0.76 |
E2E_Evaluator_ui5_manifest |
1554346.1279316642 ns/iter |
1973158.7301586322 ns/iter |
0.79 |
E2E_Evaluator_unreal_engine_uproject |
341415.1580573181 ns/iter |
389425.7352941863 ns/iter |
0.88 |
E2E_Evaluator_users_array |
404449.62742785 ns/iter |
634757.3890435362 ns/iter |
0.64 |
E2E_Evaluator_vercel |
210655.4090770813 ns/iter |
226725.72402042002 ns/iter |
0.93 |
E2E_Evaluator_yamllint |
6029.230281889309 ns/iter |
6379.611421737277 ns/iter |
0.95 |
JSONLD_Catalog |
17044211.309520766 ns/iter |
20276072.294116013 ns/iter |
0.84 |
Micro_Draft4_Meta_1_No_Callback |
124.75230678838456 ns/iter |
136.63822254227338 ns/iter |
0.91 |
Micro_Draft4_Required_Properties |
644.1706140010272 ns/iter |
692.1603463749254 ns/iter |
0.93 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
15.25370336193536 ns/iter |
16.49204248200121 ns/iter |
0.92 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
7.467729694649087 ns/iter |
7.860764735744598 ns/iter |
0.95 |
Micro_Draft4_Items_Schema |
199.14726556709104 ns/iter |
227.6408549672225 ns/iter |
0.87 |
Micro_Draft4_Nested_Object |
0.9793426766228356 ns/iter |
1.1812752577569616 ns/iter |
0.83 |
Micro_Draft4_Properties_Triad_Optional |
191.2039555572761 ns/iter |
349.21856296963244 ns/iter |
0.55 |
Micro_Draft4_Properties_Triad_Closed |
159.99899685212876 ns/iter |
227.4366107847694 ns/iter |
0.70 |
Micro_Draft4_Properties_Triad_Required |
225.8956310457758 ns/iter |
264.7728128098978 ns/iter |
0.85 |
Micro_Draft4_Properties_Closed |
38.32726079188777 ns/iter |
46.40976449722157 ns/iter |
0.83 |
Micro_Draft4_Non_Recursive_Ref |
11.693223948353785 ns/iter |
13.145824977085196 ns/iter |
0.89 |
Micro_Draft4_Pattern_Properties_True |
138.54990372839967 ns/iter |
142.82413217164503 ns/iter |
0.97 |
Micro_Draft4_Ref_To_Single_Property |
7.371400022160484 ns/iter |
8.244543578363142 ns/iter |
0.89 |
Micro_Draft4_Additional_Properties_Type |
25.08573610687287 ns/iter |
27.224287172808406 ns/iter |
0.92 |
Micro_Draft4_Nested_Oneof |
36.031352362074514 ns/iter |
37.693290916683296 ns/iter |
0.96 |
Micro_Draft4_Short_Enum |
4.612087662810701 ns/iter |
5.0977520899982665 ns/iter |
0.90 |
Micro_Draft4_Long_Enum |
9.140807284951268 ns/iter |
9.752231244908614 ns/iter |
0.94 |
Micro_Draft4_Long_Enum_Short_Strings |
6.187640236435475 ns/iter |
8.038618585176591 ns/iter |
0.77 |
Micro_Draft4_Type_Object |
2.267937411077205 ns/iter |
3.2389453376576838 ns/iter |
0.70 |
Micro_Draft4_Ref_Single_100 |
1661159.064665603 ns/iter |
2323059.4190144534 ns/iter |
0.72 |
Micro_Draft4_Compile_Ref_Many_Nested |
1142026.016474566 ns/iter |
1720099.943052349 ns/iter |
0.66 |
Micro_Draft4_Compile_Wrap |
1793251.061224519 ns/iter |
2612905.8219176116 ns/iter |
0.69 |
Micro_Draft6_Property_Names |
89.09499811101551 ns/iter |
121.76965561637908 ns/iter |
0.73 |
Micro_Draft6_Compile_FHIR |
9396466333.000034 ns/iter |
20136619916.99996 ns/iter |
0.47 |
Micro_Draft7_If_Then_Else |
16.15435069506962 ns/iter |
23.258991731272317 ns/iter |
0.69 |
Micro_2019_09_Unevaluated_Properties |
25.07665594910404 ns/iter |
36.52461245698592 ns/iter |
0.69 |
Micro_2019_09_Compile_Wrap |
263724736.0000098 ns/iter |
602803583.9999574 ns/iter |
0.44 |
Micro_2020_12_Dynamic_Ref |
553.8314486321045 ns/iter |
1190.9150550885897 ns/iter |
0.47 |
Micro_2020_12_Dynamic_Ref_Single |
2.249267174136748 ns/iter |
10.383453749998353 ns/iter |
0.22 |
Micro_2020_12_Simple_Output_Mask |
751.915189644035 ns/iter |
1098.453102581577 ns/iter |
0.68 |
Micro_2020_12_Simple_Output_Annotations |
55826.963072018996 ns/iter |
73966.87166337723 ns/iter |
0.75 |
Micro_2020_12_Simple_Output_Annotation_Dropping |
1439495.6367518287 ns/iter |
1794318.3621174137 ns/iter |
0.80 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
720592.3689617733 ns/iter |
869987.8691981706 ns/iter |
0.83 |
Micro_2020_12_Exhaustive_Deep_Numeric |
4785.5067181319255 ns/iter |
5351.13332708324 ns/iter |
0.89 |
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput |
35408.63471980173 ns/iter |
51443.643545045226 ns/iter |
0.69 |
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput |
13745.59504301012 ns/iter |
17397.527881140923 ns/iter |
0.79 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail |
81.49783238652005 ns/iter |
98.10981593655777 ns/iter |
0.83 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput |
3008.4676319572222 ns/iter |
4046.497918586971 ns/iter |
0.74 |
Alterschema_Check_Readibility_ISO_Language_Set_3 |
204774430.66662696 ns/iter |
278047708.33328503 ns/iter |
0.74 |
Alterschema_Check_Readibility_OMC |
57967635.4166736 ns/iter |
80481226.88887817 ns/iter |
0.72 |
Alterschema_Check_Readibility_KrakenD |
614275207.9999809 ns/iter |
910044707.9999868 ns/iter |
0.67 |
Alterschema_Apply_Readibility_KrakenD |
65890229333.99997 ns/iter |
76003071873.99994 ns/iter |
0.87 |
Alterschema_Check_Invalid_External_Refs |
157231551.99998474 ns/iter |
168283812.50002167 ns/iter |
0.93 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
JavaScript (macos/llvm)
Details
| Benchmark suite | Current: 471e684 | Previous: b1d768c | Ratio |
|---|---|---|---|
E2E_Evaluator_adaptivecard |
89119 ns |
93738 ns |
0.95 |
E2E_Evaluator_ansible-meta |
334225 ns |
332863 ns |
1.00 |
E2E_Evaluator_aws-cdk |
108321 ns |
114317 ns |
0.95 |
E2E_Evaluator_babelrc |
271776 ns |
253026 ns |
1.07 |
E2E_Evaluator_cerebrum-criminal-case |
1533283 ns |
1557304 ns |
0.98 |
E2E_Evaluator_clang-format |
171778 ns |
169280 ns |
1.01 |
E2E_Evaluator_cmake-presets |
11180906 ns |
11731542 ns |
0.95 |
E2E_Evaluator_code-climate |
344101 ns |
368790 ns |
0.93 |
E2E_Evaluator_cql2 |
919374 ns |
949315 ns |
0.97 |
E2E_Evaluator_cspell |
924651 ns |
1074559 ns |
0.86 |
E2E_Evaluator_cypress |
496612 ns |
493648 ns |
1.01 |
E2E_Evaluator_deno |
608716 ns |
620411 ns |
0.98 |
E2E_Evaluator_dependabot |
712415 ns |
696004 ns |
1.02 |
E2E_Evaluator_draft-04 |
13988035 ns |
14081650 ns |
0.99 |
E2E_Evaluator_fabric-mod |
1300927 ns |
1343185 ns |
0.97 |
E2E_Evaluator_geojson |
14977368 ns |
16111140 ns |
0.93 |
E2E_Evaluator_gitpod-configuration |
452874 ns |
636183 ns |
0.71 |
E2E_Evaluator_helm-chart-lock |
789035 ns |
906353 ns |
0.87 |
E2E_Evaluator_importmap |
200289 ns |
202569 ns |
0.99 |
E2E_Evaluator_jasmine |
197871 ns |
195297 ns |
1.01 |
E2E_Evaluator_jsconfig |
787795 ns |
797136 ns |
0.99 |
E2E_Evaluator_jshintrc |
1850882 ns |
1856582 ns |
1.00 |
E2E_Evaluator_krakend |
407277 ns |
418010 ns |
0.97 |
E2E_Evaluator_lazygit |
257293 ns |
302126 ns |
0.85 |
E2E_Evaluator_lerna |
302304 ns |
297101 ns |
1.02 |
E2E_Evaluator_nest-cli |
382247 ns |
382448 ns |
1.00 |
E2E_Evaluator_omc |
69009 ns |
69341 ns |
1.00 |
E2E_Evaluator_omnisharp |
926642 ns |
930460 ns |
1.00 |
E2E_Evaluator_openapi |
14495947 ns |
14218554 ns |
1.02 |
E2E_Evaluator_pre-commit-hooks |
1290269 ns |
1210739 ns |
1.07 |
E2E_Evaluator_pulumi |
1302110 ns |
1409559 ns |
0.92 |
E2E_Evaluator_semantic-release |
163465 ns |
164548 ns |
0.99 |
E2E_Evaluator_stale |
259656 ns |
273574 ns |
0.95 |
E2E_Evaluator_stylecop |
663891 ns |
709582 ns |
0.94 |
E2E_Evaluator_tmuxinator |
152035 ns |
179086 ns |
0.85 |
E2E_Evaluator_ui5 |
1444953 ns |
1949435 ns |
0.74 |
E2E_Evaluator_ui5-manifest |
7761182 ns |
9649143 ns |
0.80 |
E2E_Evaluator_unreal-engine-uproject |
1084221 ns |
1231724 ns |
0.88 |
E2E_Evaluator_users-array |
1982927 ns |
2821081 ns |
0.70 |
E2E_Evaluator_vercel |
672952 ns |
783917 ns |
0.86 |
E2E_Evaluator_yamllint |
22026 ns |
23749 ns |
0.93 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
Details
| Benchmark suite | Current: 471e684 | Previous: b1d768c | Ratio |
|---|---|---|---|
Schema_Iterator_ISO_Language |
2633417.4448667923 ns/iter |
2834633.426829445 ns/iter |
0.93 |
Schema_Tracker_ISO_Language |
3785821.5675675417 ns/iter |
4348839.913044013 ns/iter |
0.87 |
Schema_Tracker_ISO_Language_To_JSON |
16792087.953487765 ns/iter |
20674371.878785126 ns/iter |
0.81 |
Schema_Frame_WoT_References |
3566309.852040641 ns/iter |
4200105.67857178 ns/iter |
0.85 |
Schema_Frame_OMC_References |
15781142.878048874 ns/iter |
18397289.815790206 ns/iter |
0.86 |
Schema_Frame_OMC_Locations |
14627169.833332233 ns/iter |
16703023.146341942 ns/iter |
0.88 |
Schema_Frame_ISO_Language_Locations |
76943333.62499605 ns/iter |
96736937.42856164 ns/iter |
0.80 |
Schema_Frame_KrakenD_References |
32062181.272728845 ns/iter |
35886894.550003484 ns/iter |
0.89 |
Schema_Frame_KrakenD_Reachable |
498608149.99999547 ns/iter |
717160284.0001014 ns/iter |
0.70 |
Schema_Frame_ISO_Language_Locations_To_JSON |
103733308.0000053 ns/iter |
117343582.60000591 ns/iter |
0.88 |
Schema_Frame_Many_Resources_References |
284061849.5000058 ns/iter |
353098637.4999543 ns/iter |
0.80 |
Schema_Bundle_Meta_2020_12 |
1103093.167723958 ns/iter |
1417068.6796713206 ns/iter |
0.78 |
Schema_Format_ISO_Language_To_JSON |
88241550.66666764 ns/iter |
103832479.00001283 ns/iter |
0.85 |
E2E_Compiler_adaptivecard |
47229876.35714 ns/iter |
56143233.15384913 ns/iter |
0.84 |
E2E_Compiler_ansible_meta |
19803418.69444323 ns/iter |
22874361.290321086 ns/iter |
0.87 |
E2E_Compiler_aws_cdk |
239580.49658703525 ns/iter |
295241.3530664395 ns/iter |
0.81 |
E2E_Compiler_babelrc |
1782944.1479593744 ns/iter |
2137490.6276923865 ns/iter |
0.83 |
E2E_Compiler_clang_format |
12707215.803571004 ns/iter |
14603978.791666823 ns/iter |
0.87 |
E2E_Compiler_cmake_presets |
19933459.65714265 ns/iter |
24066231.999999497 ns/iter |
0.83 |
E2E_Compiler_code_climate |
1806840.1295334657 ns/iter |
2174337.3659305703 ns/iter |
0.83 |
E2E_Compiler_cql2 |
9978298.671428222 ns/iter |
12099969.12068971 ns/iter |
0.82 |
E2E_Compiler_cspell |
17750905.000000857 ns/iter |
21363882.121211946 ns/iter |
0.83 |
E2E_Compiler_cypress |
3042841.7173909666 ns/iter |
3601027.953367723 ns/iter |
0.84 |
E2E_Compiler_deno |
5416274.395349157 ns/iter |
6254289.142857163 ns/iter |
0.87 |
E2E_Compiler_dependabot |
2741724.8235295513 ns/iter |
3161997.946188425 ns/iter |
0.87 |
E2E_Compiler_draft_04 |
1877652.7700534635 ns/iter |
2276667.7864080276 ns/iter |
0.82 |
E2E_Compiler_fabric_mod |
3295759.8873241814 ns/iter |
3931979.3407823667 ns/iter |
0.84 |
E2E_Compiler_geojson |
16058066.63636403 ns/iter |
18758359.57894735 ns/iter |
0.86 |
E2E_Compiler_gitpod_configuration |
3507602.9452735633 ns/iter |
4225899.591716429 ns/iter |
0.83 |
E2E_Compiler_helm_chart_lock |
446626.8310854085 ns/iter |
535208.723533872 ns/iter |
0.83 |
E2E_Compiler_importmap |
176132.51987923018 ns/iter |
214770.51824593256 ns/iter |
0.82 |
E2E_Compiler_jasmine |
922467.26287982 ns/iter |
1132887.760195593 ns/iter |
0.81 |
E2E_Compiler_jshintrc |
2928042.4208333027 ns/iter |
3455277.487562319 ns/iter |
0.85 |
E2E_Compiler_jsconfig |
15853882.272727497 ns/iter |
18060270.46153793 ns/iter |
0.88 |
E2E_Compiler_krakend |
111664219.57143159 ns/iter |
125813420.49999952 ns/iter |
0.89 |
E2E_Compiler_lazygit |
23851677.27586263 ns/iter |
27858966.51999792 ns/iter |
0.86 |
E2E_Compiler_lerna |
1100352.6847825754 ns/iter |
1332885.5653847647 ns/iter |
0.83 |
E2E_Compiler_nest_cli |
5316922.194029968 ns/iter |
6096146.070175118 ns/iter |
0.87 |
E2E_Compiler_omc |
119325896.1666667 ns/iter |
140973819.4000056 ns/iter |
0.85 |
E2E_Compiler_omnisharp |
4632205.000000386 ns/iter |
5330756.221374448 ns/iter |
0.87 |
E2E_Compiler_openapi |
18026691.64102647 ns/iter |
20793385.878787927 ns/iter |
0.87 |
E2E_Compiler_pre_commit_hooks |
3638689.7357512866 ns/iter |
4146270.0416662386 ns/iter |
0.88 |
E2E_Compiler_pulumi |
2827500.1759998305 ns/iter |
3379636.5458934326 ns/iter |
0.84 |
E2E_Compiler_semantic_release |
1039804.509687113 ns/iter |
1315184.528517116 ns/iter |
0.79 |
E2E_Compiler_stale |
1062910.8318181406 ns/iter |
1298969.5387454035 ns/iter |
0.82 |
E2E_Compiler_stylecop |
3980209.779660596 ns/iter |
4595441.68627432 ns/iter |
0.87 |
E2E_Compiler_tmuxinator |
1278837.6405109605 ns/iter |
1572218.7174889357 ns/iter |
0.81 |
E2E_Compiler_ui5 |
36924936.21052731 ns/iter |
44458671.68750084 ns/iter |
0.83 |
E2E_Compiler_ui5_manifest |
249893193.9999996 ns/iter |
284008522.00002193 ns/iter |
0.88 |
E2E_Compiler_unreal_engine_uproject |
3216161.3715600553 ns/iter |
3740369.1075274195 ns/iter |
0.86 |
E2E_Compiler_users_array |
577805.2046204897 ns/iter |
745718.8785942227 ns/iter |
0.77 |
E2E_Compiler_vercel |
9395773.675676636 ns/iter |
11395488.770491567 ns/iter |
0.82 |
E2E_Compiler_yamllint |
221248.4427891915 ns/iter |
271841.8970242877 ns/iter |
0.81 |
E2E_Evaluator_adaptivecard |
21295.989759051994 ns/iter |
21126.04255515499 ns/iter |
1.01 |
E2E_Evaluator_ansible_meta |
180703.312596008 ns/iter |
189911.2193054363 ns/iter |
0.95 |
E2E_Evaluator_aws_cdk |
35887.61674303825 ns/iter |
41649.18027495226 ns/iter |
0.86 |
E2E_Evaluator_babelrc |
77620.07459898457 ns/iter |
102414.48584421504 ns/iter |
0.76 |
E2E_Evaluator_cerebrum_criminal_case |
880570.3013870183 ns/iter |
1051655.9517544953 ns/iter |
0.84 |
E2E_Evaluator_clang_format |
90980.17999493417 ns/iter |
102974.85334527523 ns/iter |
0.88 |
E2E_Evaluator_cmake_presets |
4223917.622516789 ns/iter |
4439530.493589799 ns/iter |
0.95 |
E2E_Evaluator_code_climate |
131888.5286028621 ns/iter |
168767.9854651043 ns/iter |
0.78 |
E2E_Evaluator_cql2 |
157474.21894691008 ns/iter |
170055.95452320718 ns/iter |
0.93 |
E2E_Evaluator_cspell |
489710.7948718497 ns/iter |
578880.8035263834 ns/iter |
0.85 |
E2E_Evaluator_cypress |
137469.72080719986 ns/iter |
167450.76188201545 ns/iter |
0.82 |
E2E_Evaluator_deno |
209086.10290158066 ns/iter |
301913.0540190562 ns/iter |
0.69 |
E2E_Evaluator_dependabot |
256646.60690910587 ns/iter |
293731.8578680081 ns/iter |
0.87 |
E2E_Evaluator_draft_04 |
7596601.446808331 ns/iter |
7398912.135135708 ns/iter |
1.03 |
E2E_Evaluator_fabric_mod |
537270.5675038915 ns/iter |
637995.9642856856 ns/iter |
0.84 |
E2E_Evaluator_geojson |
15838872.333333818 ns/iter |
18626080.45945996 ns/iter |
0.85 |
E2E_Evaluator_gitpod_configuration |
170834.83901842555 ns/iter |
206618.6555819431 ns/iter |
0.83 |
E2E_Evaluator_helm_chart_lock |
180188.32974079784 ns/iter |
390958.2412060486 ns/iter |
0.46 |
E2E_Evaluator_importmap |
41283.62357571063 ns/iter |
35473.49717168997 ns/iter |
1.16 |
E2E_Evaluator_jasmine |
78981.92620634506 ns/iter |
106940.47878046507 ns/iter |
0.74 |
E2E_Evaluator_jshintrc |
928979.802631602 ns/iter |
1161540.3421927888 ns/iter |
0.80 |
E2E_Evaluator_jsconfig |
325866.3093457561 ns/iter |
366558.20219435316 ns/iter |
0.89 |
E2E_Evaluator_krakend |
150080.42079419375 ns/iter |
166658.2175255379 ns/iter |
0.90 |
E2E_Evaluator_lazygit |
104643.09295015818 ns/iter |
117842.65686932082 ns/iter |
0.89 |
E2E_Evaluator_lerna |
92730.10399590102 ns/iter |
134627.6292331595 ns/iter |
0.69 |
E2E_Evaluator_nest_cli |
144846.26874613957 ns/iter |
174122.38152307319 ns/iter |
0.83 |
E2E_Evaluator_omc |
15027.33278027913 ns/iter |
15499.166677452682 ns/iter |
0.97 |
E2E_Evaluator_omnisharp |
440751.5085281062 ns/iter |
530397.1524163022 ns/iter |
0.83 |
E2E_Evaluator_openapi |
12025431.397060014 ns/iter |
11635032.999999264 ns/iter |
1.03 |
E2E_Evaluator_pre_commit_hooks |
385200.4917127403 ns/iter |
470884.9785090468 ns/iter |
0.82 |
E2E_Evaluator_pulumi |
538139.9652240844 ns/iter |
730854.2182952735 ns/iter |
0.74 |
E2E_Evaluator_semantic_release |
67377.98732572491 ns/iter |
84660.526360538 ns/iter |
0.80 |
E2E_Evaluator_stale |
118961.99780145728 ns/iter |
135897.80541586125 ns/iter |
0.88 |
E2E_Evaluator_stylecop |
213765.79381129314 ns/iter |
247545.10781196353 ns/iter |
0.86 |
E2E_Evaluator_tmuxinator |
67718.91490379868 ns/iter |
86652.37476529823 ns/iter |
0.78 |
E2E_Evaluator_ui5 |
402367.7695402475 ns/iter |
441272.48507937195 ns/iter |
0.91 |
E2E_Evaluator_ui5_manifest |
1972654.3323944062 ns/iter |
2430776.4507043464 ns/iter |
0.81 |
E2E_Evaluator_unreal_engine_uproject |
343951.7583170423 ns/iter |
429067.8939951271 ns/iter |
0.80 |
E2E_Evaluator_users_array |
497605.60329981794 ns/iter |
614844.8613333433 ns/iter |
0.81 |
E2E_Evaluator_vercel |
210250.31845415468 ns/iter |
302057.16817592125 ns/iter |
0.70 |
E2E_Evaluator_yamllint |
6849.377218499105 ns/iter |
7892.789970659995 ns/iter |
0.87 |
JSONLD_Catalog |
21714301.805556286 ns/iter |
20018899.694444295 ns/iter |
1.08 |
Micro_Draft4_Meta_1_No_Callback |
157.53961643808137 ns/iter |
157.85689427412694 ns/iter |
1.00 |
Micro_Draft4_Required_Properties |
714.7339226591313 ns/iter |
714.3298039634716 ns/iter |
1.00 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
20.967961113208766 ns/iter |
20.068252774178834 ns/iter |
1.04 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
9.142017399772675 ns/iter |
9.147067702634976 ns/iter |
1.00 |
Micro_Draft4_Items_Schema |
211.9842876519281 ns/iter |
262.17713885246656 ns/iter |
0.81 |
Micro_Draft4_Nested_Object |
1.017960288542728 ns/iter |
1.4760419225345105 ns/iter |
0.69 |
Micro_Draft4_Properties_Triad_Optional |
259.4085076347058 ns/iter |
267.2205229742771 ns/iter |
0.97 |
Micro_Draft4_Properties_Triad_Closed |
210.68100366662554 ns/iter |
222.13175697225057 ns/iter |
0.95 |
Micro_Draft4_Properties_Triad_Required |
268.3384215231402 ns/iter |
291.14417481374744 ns/iter |
0.92 |
Micro_Draft4_Properties_Closed |
52.74679538853627 ns/iter |
51.946278707373956 ns/iter |
1.02 |
Micro_Draft4_Non_Recursive_Ref |
12.629538686222547 ns/iter |
13.646093830601234 ns/iter |
0.93 |
Micro_Draft4_Pattern_Properties_True |
113.49343754454833 ns/iter |
138.86765077085815 ns/iter |
0.82 |
Micro_Draft4_Ref_To_Single_Property |
9.101231174961004 ns/iter |
9.308927892154891 ns/iter |
0.98 |
Micro_Draft4_Additional_Properties_Type |
29.462013831406395 ns/iter |
36.454422963002614 ns/iter |
0.81 |
Micro_Draft4_Nested_Oneof |
46.10453253499908 ns/iter |
51.85591191432136 ns/iter |
0.89 |
Micro_Draft4_Short_Enum |
8.47284203434252 ns/iter |
9.429038552461389 ns/iter |
0.90 |
Micro_Draft4_Long_Enum |
11.462029002736191 ns/iter |
13.62627138048158 ns/iter |
0.84 |
Micro_Draft4_Long_Enum_Short_Strings |
8.471761119926805 ns/iter |
9.380711481182107 ns/iter |
0.90 |
Micro_Draft4_Type_Object |
2.733248650787183 ns/iter |
2.868044204842045 ns/iter |
0.95 |
Micro_Draft4_Ref_Single_100 |
1763096.6416040487 ns/iter |
2122205.155688642 ns/iter |
0.83 |
Micro_Draft4_Compile_Ref_Many_Nested |
1291770.7926604685 ns/iter |
1594598.9750567325 ns/iter |
0.81 |
Micro_Draft4_Compile_Wrap |
1796552.922879074 ns/iter |
2189311.3084113626 ns/iter |
0.82 |
Micro_Draft6_Property_Names |
103.2478752231761 ns/iter |
154.4665475265613 ns/iter |
0.67 |
Micro_Draft6_Compile_FHIR |
12568396522.000057 ns/iter |
17444665046.999943 ns/iter |
0.72 |
Micro_Draft7_If_Then_Else |
20.21822146205131 ns/iter |
25.46477106212837 ns/iter |
0.79 |
Micro_2019_09_Unevaluated_Properties |
19.041050242313528 ns/iter |
24.73618505777797 ns/iter |
0.77 |
Micro_2019_09_Compile_Wrap |
255499105.66663432 ns/iter |
265384333.66666445 ns/iter |
0.96 |
Micro_2020_12_Dynamic_Ref |
553.8882958407339 ns/iter |
655.1413549724742 ns/iter |
0.85 |
Micro_2020_12_Dynamic_Ref_Single |
2.7366031398258666 ns/iter |
2.9275001060021655 ns/iter |
0.93 |
Micro_2020_12_Simple_Output_Mask |
799.7118955332365 ns/iter |
928.5770366898381 ns/iter |
0.86 |
Micro_2020_12_Simple_Output_Annotations |
48512.46087799803 ns/iter |
64759.08978583988 ns/iter |
0.75 |
Micro_2020_12_Simple_Output_Annotation_Dropping |
1184888.7274307096 ns/iter |
1484033.170886064 ns/iter |
0.80 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
730251.8307045883 ns/iter |
915747.0811518308 ns/iter |
0.80 |
Micro_2020_12_Exhaustive_Deep_Numeric |
7089.794997779741 ns/iter |
6825.8710314199425 ns/iter |
1.04 |
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput |
36288.9814968756 ns/iter |
43835.52776233907 ns/iter |
0.83 |
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput |
18332.299978898627 ns/iter |
18528.02093837808 ns/iter |
0.99 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail |
118.14469668604812 ns/iter |
110.94138361220206 ns/iter |
1.06 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput |
1994.6308153588413 ns/iter |
2419.784580192318 ns/iter |
0.82 |
Alterschema_Check_Readibility_ISO_Language_Set_3 |
267993251.66666675 ns/iter |
335293422.50000125 ns/iter |
0.80 |
Alterschema_Check_Readibility_OMC |
69209219.49999866 ns/iter |
91975146.75000207 ns/iter |
0.75 |
Alterschema_Check_Readibility_KrakenD |
1013037608.99998 ns/iter |
1554834782.0000572 ns/iter |
0.65 |
Alterschema_Apply_Readibility_KrakenD |
100450126580.99995 ns/iter |
145691202526.99997 ns/iter |
0.69 |
Alterschema_Check_Invalid_External_Refs |
218408053.66665944 ns/iter |
185062574.9999608 ns/iter |
1.18 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
JavaScript (linux/llvm)
Details
| Benchmark suite | Current: 471e684 | Previous: b1d768c | Ratio |
|---|---|---|---|
E2E_Evaluator_adaptivecard |
94069 ns |
104882 ns |
0.90 |
E2E_Evaluator_ansible-meta |
426364 ns |
457814 ns |
0.93 |
E2E_Evaluator_aws-cdk |
99506 ns |
131597 ns |
0.76 |
E2E_Evaluator_babelrc |
284710 ns |
344965 ns |
0.83 |
E2E_Evaluator_cerebrum-criminal-case |
2077846 ns |
2245192 ns |
0.93 |
E2E_Evaluator_clang-format |
216327 ns |
264283 ns |
0.82 |
E2E_Evaluator_cmake-presets |
14569697 ns |
17422903 ns |
0.84 |
E2E_Evaluator_code-climate |
406095 ns |
517942 ns |
0.78 |
E2E_Evaluator_cql2 |
964508 ns |
1026335 ns |
0.94 |
E2E_Evaluator_cspell |
1314819 ns |
1726858 ns |
0.76 |
E2E_Evaluator_cypress |
690698 ns |
967429 ns |
0.71 |
E2E_Evaluator_deno |
868211 ns |
1043432 ns |
0.83 |
E2E_Evaluator_dependabot |
880599 ns |
1038476 ns |
0.85 |
E2E_Evaluator_draft-04 |
18211985 ns |
19081070 ns |
0.95 |
E2E_Evaluator_fabric-mod |
2015713 ns |
2309560 ns |
0.87 |
E2E_Evaluator_geojson |
23515705 ns |
24578823 ns |
0.96 |
E2E_Evaluator_gitpod-configuration |
625672 ns |
687480 ns |
0.91 |
E2E_Evaluator_helm-chart-lock |
790921 ns |
978790 ns |
0.81 |
E2E_Evaluator_importmap |
211554 ns |
298384 ns |
0.71 |
E2E_Evaluator_jasmine |
219029 ns |
278635 ns |
0.79 |
E2E_Evaluator_jsconfig |
1189164 ns |
1403211 ns |
0.85 |
E2E_Evaluator_jshintrc |
2398338 ns |
2976504 ns |
0.81 |
E2E_Evaluator_krakend |
504318 ns |
549308 ns |
0.92 |
E2E_Evaluator_lazygit |
383028 ns |
452539 ns |
0.85 |
E2E_Evaluator_lerna |
362637 ns |
447203 ns |
0.81 |
E2E_Evaluator_nest-cli |
483053 ns |
619836 ns |
0.78 |
E2E_Evaluator_omc |
74547 ns |
85890 ns |
0.87 |
E2E_Evaluator_omnisharp |
1199401 ns |
1511816 ns |
0.79 |
E2E_Evaluator_openapi |
17802727 ns |
20952211 ns |
0.85 |
E2E_Evaluator_pre-commit-hooks |
1681420 ns |
2042115 ns |
0.82 |
E2E_Evaluator_pulumi |
1666136 ns |
2001092 ns |
0.83 |
E2E_Evaluator_semantic-release |
181962 ns |
219500 ns |
0.83 |
E2E_Evaluator_stale |
306760 ns |
340771 ns |
0.90 |
E2E_Evaluator_stylecop |
983948 ns |
1211191 ns |
0.81 |
E2E_Evaluator_tmuxinator |
182438 ns |
286173 ns |
0.64 |
E2E_Evaluator_ui5 |
1694161 ns |
1862470 ns |
0.91 |
E2E_Evaluator_ui5-manifest |
7625134 ns |
9067082 ns |
0.84 |
E2E_Evaluator_unreal-engine-uproject |
1278906 ns |
1667253 ns |
0.77 |
E2E_Evaluator_users-array |
2307359 ns |
2754278 ns |
0.84 |
E2E_Evaluator_vercel |
803567 ns |
1045414 ns |
0.77 |
E2E_Evaluator_yamllint |
19225 ns |
24771 ns |
0.78 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
Details
| Benchmark suite | Current: 471e684 | Previous: b1d768c | Ratio |
|---|---|---|---|
Alterschema_Check_Readibility_ISO_Language_Set_3 |
368356088.00004137 ns/iter |
371023914.50002867 ns/iter |
0.99 |
Alterschema_Check_Readibility_OMC |
106447505.42857245 ns/iter |
104373100.14283086 ns/iter |
1.02 |
Alterschema_Check_Readibility_KrakenD |
1435939097.0000732 ns/iter |
1464898131.9999166 ns/iter |
0.98 |
Alterschema_Apply_Readibility_KrakenD |
137600883293.00015 ns/iter |
136297887609.0001 ns/iter |
1.01 |
Alterschema_Check_Invalid_External_Refs |
300524417.0000196 ns/iter |
291082830.99992603 ns/iter |
1.03 |
Micro_2020_12_Dynamic_Ref |
804.1965870322041 ns/iter |
800.9304526320205 ns/iter |
1.00 |
Micro_2020_12_Dynamic_Ref_Single |
4.5710552849874615 ns/iter |
4.414654988510613 ns/iter |
1.04 |
Micro_2020_12_Simple_Output_Mask |
1075.913095117839 ns/iter |
1076.9032306942102 ns/iter |
1.00 |
Micro_2020_12_Simple_Output_Annotations |
71129.99363123541 ns/iter |
70501.65857883904 ns/iter |
1.01 |
Micro_2020_12_Simple_Output_Annotation_Dropping |
1816906.5374675281 ns/iter |
1788020.5431472554 ns/iter |
1.02 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
1084612.4645061756 ns/iter |
1071596.1470136936 ns/iter |
1.01 |
Micro_2020_12_Exhaustive_Deep_Numeric |
9284.22173334362 ns/iter |
9130.783008127928 ns/iter |
1.02 |
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput |
51484.2586139333 ns/iter |
51199.10537633655 ns/iter |
1.01 |
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput |
26884.24143902086 ns/iter |
27221.094872088164 ns/iter |
0.99 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail |
160.721965598784 ns/iter |
166.7399613123978 ns/iter |
0.96 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput |
3030.3510896411076 ns/iter |
3022.5552742905757 ns/iter |
1.00 |
Micro_2019_09_Unevaluated_Properties |
30.595123098383866 ns/iter |
30.679407037490268 ns/iter |
1.00 |
Micro_2019_09_Compile_Wrap |
354440287.49998325 ns/iter |
307154519.50004536 ns/iter |
1.15 |
Micro_Draft7_If_Then_Else |
25.218189938491804 ns/iter |
25.001646184494568 ns/iter |
1.01 |
Micro_Draft6_Property_Names |
155.8339451668381 ns/iter |
150.55591450522323 ns/iter |
1.04 |
Micro_Draft6_Compile_FHIR |
19583708339.99993 ns/iter |
14586103190.999893 ns/iter |
1.34 |
Micro_Draft4_Meta_1_No_Callback |
181.68938502515329 ns/iter |
180.73029861063876 ns/iter |
1.01 |
Micro_Draft4_Required_Properties |
906.3373523720192 ns/iter |
936.615570143826 ns/iter |
0.97 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
21.83501503959083 ns/iter |
21.916600022753638 ns/iter |
1.00 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
15.840652984206072 ns/iter |
16.18131000417418 ns/iter |
0.98 |
Micro_Draft4_Items_Schema |
294.60201455673865 ns/iter |
291.6112195765388 ns/iter |
1.01 |
Micro_Draft4_Nested_Object |
2.110960402323133 ns/iter |
2.4607795538300468 ns/iter |
0.86 |
Micro_Draft4_Properties_Triad_Optional |
422.13063005676264 ns/iter |
439.0018143620703 ns/iter |
0.96 |
Micro_Draft4_Properties_Triad_Closed |
388.16853648898376 ns/iter |
350.7496737009135 ns/iter |
1.11 |
Micro_Draft4_Properties_Triad_Required |
473.3653114652 ns/iter |
489.8157935591932 ns/iter |
0.97 |
Micro_Draft4_Properties_Closed |
66.29570634201774 ns/iter |
64.82236326135079 ns/iter |
1.02 |
Micro_Draft4_Non_Recursive_Ref |
8.799604662598316 ns/iter |
8.799058038804436 ns/iter |
1.00 |
Micro_Draft4_Pattern_Properties_True |
181.4675056440452 ns/iter |
186.4836327211529 ns/iter |
0.97 |
Micro_Draft4_Ref_To_Single_Property |
16.27580721147498 ns/iter |
16.180367163079982 ns/iter |
1.01 |
Micro_Draft4_Additional_Properties_Type |
14.789728361039217 ns/iter |
13.94382747425399 ns/iter |
1.06 |
Micro_Draft4_Nested_Oneof |
63.34213727954704 ns/iter |
63.97919741272213 ns/iter |
0.99 |
Micro_Draft4_Short_Enum |
14.53708791676939 ns/iter |
14.543522106560108 ns/iter |
1.00 |
Micro_Draft4_Long_Enum |
14.421663936311443 ns/iter |
13.368940031120857 ns/iter |
1.08 |
Micro_Draft4_Long_Enum_Short_Strings |
14.463416885628853 ns/iter |
14.735055857798939 ns/iter |
0.98 |
Micro_Draft4_Type_Object |
4.574830732359472 ns/iter |
4.571379985886832 ns/iter |
1.00 |
Micro_Draft4_Ref_Single_100 |
2447844.5000002123 ns/iter |
2433707.52430552 ns/iter |
1.01 |
Micro_Draft4_Compile_Ref_Many_Nested |
1816593.7194804759 ns/iter |
1812519.1766232871 ns/iter |
1.00 |
Micro_Draft4_Compile_Wrap |
2599781.8999999086 ns/iter |
2581376.0147604113 ns/iter |
1.01 |
JSONLD_Catalog |
29784781.333328664 ns/iter |
26146232.599994615 ns/iter |
1.14 |
E2E_Compiler_adaptivecard |
70058949.89999887 ns/iter |
61963357.72727418 ns/iter |
1.13 |
E2E_Compiler_ansible_meta |
29002024.291666355 ns/iter |
27962374.039998394 ns/iter |
1.04 |
E2E_Compiler_aws_cdk |
354984.74936710275 ns/iter |
346872.8402778322 ns/iter |
1.02 |
E2E_Compiler_babelrc |
2564764.4227934936 ns/iter |
2508765.0645155106 ns/iter |
1.02 |
E2E_Compiler_clang_format |
18226844.81579161 ns/iter |
17542688.102565035 ns/iter |
1.04 |
E2E_Compiler_cmake_presets |
28032657.520006977 ns/iter |
27105561.499997046 ns/iter |
1.03 |
E2E_Compiler_code_climate |
2603108.4163568364 ns/iter |
2558003.0182480346 ns/iter |
1.02 |
E2E_Compiler_cql2 |
14758437.297872506 ns/iter |
14146024.759998 ns/iter |
1.04 |
E2E_Compiler_cspell |
25085644.99999823 ns/iter |
24275616.482758906 ns/iter |
1.03 |
E2E_Compiler_cypress |
4193176.246987155 ns/iter |
4181759.263472943 ns/iter |
1.00 |
E2E_Compiler_deno |
7945794.875000316 ns/iter |
7824537.955056246 ns/iter |
1.02 |
E2E_Compiler_dependabot |
3935708.7262566523 ns/iter |
3823875.7049185936 ns/iter |
1.03 |
E2E_Compiler_draft_04 |
2737484.734375073 ns/iter |
2691653.421456332 ns/iter |
1.02 |
E2E_Compiler_fabric_mod |
4723906.648648976 ns/iter |
4675834.593334305 ns/iter |
1.01 |
E2E_Compiler_geojson |
23919602.31035102 ns/iter |
22347363.225802135 ns/iter |
1.07 |
E2E_Compiler_gitpod_configuration |
5011019.779999515 ns/iter |
4916712.887324407 ns/iter |
1.02 |
E2E_Compiler_helm_chart_lock |
646917.213953625 ns/iter |
635106.6363637355 ns/iter |
1.02 |
E2E_Compiler_importmap |
260886.65826220968 ns/iter |
254416.8821182325 ns/iter |
1.03 |
E2E_Compiler_jasmine |
1348181.4450865113 ns/iter |
1306390.3996244916 ns/iter |
1.03 |
E2E_Compiler_jshintrc |
4201063.622754654 ns/iter |
4064796.116279541 ns/iter |
1.03 |
E2E_Compiler_jsconfig |
22138235.437502373 ns/iter |
21147558.303034723 ns/iter |
1.05 |
E2E_Compiler_krakend |
151852994.75001556 ns/iter |
140501141.0000043 ns/iter |
1.08 |
E2E_Compiler_lazygit |
34896642.49999578 ns/iter |
32685950.952381536 ns/iter |
1.07 |
E2E_Compiler_lerna |
1577947.1126122829 ns/iter |
1562981.7190263532 ns/iter |
1.01 |
E2E_Compiler_nest_cli |
7395196.126315951 ns/iter |
7210823.587627733 ns/iter |
1.03 |
E2E_Compiler_omc |
180462751.74998528 ns/iter |
164312600.24995708 ns/iter |
1.10 |
E2E_Compiler_omnisharp |
6635621.849057933 ns/iter |
6453202.90825587 ns/iter |
1.03 |
E2E_Compiler_openapi |
26032791.37036696 ns/iter |
25365369.928571064 ns/iter |
1.03 |
E2E_Compiler_pre_commit_hooks |
5181067.411765592 ns/iter |
5108367.262772493 ns/iter |
1.01 |
E2E_Compiler_pulumi |
4020533.005882498 ns/iter |
3914659.301676566 ns/iter |
1.03 |
E2E_Compiler_semantic_release |
1539249.627192998 ns/iter |
1500687.7944326852 ns/iter |
1.03 |
E2E_Compiler_stale |
1530061.9584245128 ns/iter |
1490730.097457518 ns/iter |
1.03 |
E2E_Compiler_stylecop |
5811568.685951273 ns/iter |
5656238.024390937 ns/iter |
1.03 |
E2E_Compiler_tmuxinator |
1886809.0653949904 ns/iter |
1848770.9736149851 ns/iter |
1.02 |
E2E_Compiler_ui5 |
53754843.41666 ns/iter |
49883588.071436085 ns/iter |
1.08 |
E2E_Compiler_ui5_manifest |
354114857.00001323 ns/iter |
324056931.9999622 ns/iter |
1.09 |
E2E_Compiler_unreal_engine_uproject |
4552886.207792736 ns/iter |
4428806.861635579 ns/iter |
1.03 |
E2E_Compiler_users_array |
868924.8516210548 ns/iter |
867858.2094690633 ns/iter |
1.00 |
E2E_Compiler_vercel |
13284215.075471813 ns/iter |
12912379.96296483 ns/iter |
1.03 |
E2E_Compiler_yamllint |
326581.85522040987 ns/iter |
320846.4756657451 ns/iter |
1.02 |
E2E_Evaluator_adaptivecard |
25476.941109899013 ns/iter |
25186.099832151413 ns/iter |
1.01 |
E2E_Evaluator_ansible_meta |
264364.4855099737 ns/iter |
264213.5811064912 ns/iter |
1.00 |
E2E_Evaluator_aws_cdk |
56785.61701614551 ns/iter |
56632.19254407231 ns/iter |
1.00 |
E2E_Evaluator_babelrc |
99925.70727170014 ns/iter |
98759.61920951471 ns/iter |
1.01 |
E2E_Evaluator_cerebrum_criminal_case |
1212909.070689593 ns/iter |
1172978.2647058326 ns/iter |
1.03 |
E2E_Evaluator_clang_format |
97208.22407044831 ns/iter |
98968.87138039096 ns/iter |
0.98 |
E2E_Evaluator_cmake_presets |
7125728.067308045 ns/iter |
5178221.664122775 ns/iter |
1.38 |
E2E_Evaluator_code_climate |
201665.30619366982 ns/iter |
200440.9062591558 ns/iter |
1.01 |
E2E_Evaluator_cql2 |
215154.55982003405 ns/iter |
209622.3757847966 ns/iter |
1.03 |
E2E_Evaluator_cspell |
573579.8898095342 ns/iter |
577863.6404682746 ns/iter |
0.99 |
E2E_Evaluator_cypress |
154248.95073893518 ns/iter |
152785.30886850643 ns/iter |
1.01 |
E2E_Evaluator_deno |
319533.9972640634 ns/iter |
315543.1883993006 ns/iter |
1.01 |
E2E_Evaluator_dependabot |
365613.5625651188 ns/iter |
368156.1970802273 ns/iter |
0.99 |
E2E_Evaluator_draft_04 |
12088044.26785751 ns/iter |
9728084.808821624 ns/iter |
1.24 |
E2E_Evaluator_fabric_mod |
766653.5460600762 ns/iter |
839218.4852418766 ns/iter |
0.91 |
E2E_Evaluator_geojson |
19839972.147057027 ns/iter |
19129593.513513543 ns/iter |
1.04 |
E2E_Evaluator_gitpod_configuration |
242199.51778934285 ns/iter |
239987.3375043693 ns/iter |
1.01 |
E2E_Evaluator_helm_chart_lock |
225832.08217405132 ns/iter |
222242.8595813098 ns/iter |
1.02 |
E2E_Evaluator_importmap |
40423.641816462026 ns/iter |
40527.482666505624 ns/iter |
1.00 |
E2E_Evaluator_jasmine |
113038.7701560548 ns/iter |
113496.92164118377 ns/iter |
1.00 |
E2E_Evaluator_jshintrc |
1057717.458270169 ns/iter |
1053898.9394855928 ns/iter |
1.00 |
E2E_Evaluator_jsconfig |
419931.3537455413 ns/iter |
407296.8149253639 ns/iter |
1.03 |
E2E_Evaluator_krakend |
193504.60555556283 ns/iter |
201131.65228499347 ns/iter |
0.96 |
E2E_Evaluator_lazygit |
131253.17834518233 ns/iter |
134183.7940394943 ns/iter |
0.98 |
E2E_Evaluator_lerna |
138425.33372852622 ns/iter |
136918.26390250784 ns/iter |
1.01 |
E2E_Evaluator_nest_cli |
194040.21446736093 ns/iter |
194258.13980910523 ns/iter |
1.00 |
E2E_Evaluator_omc |
18348.36095624057 ns/iter |
18438.2298679563 ns/iter |
1.00 |
E2E_Evaluator_omnisharp |
553600.6650679071 ns/iter |
534154.7073953734 ns/iter |
1.04 |
E2E_Evaluator_openapi |
14671058.041666167 ns/iter |
12072290.942307098 ns/iter |
1.22 |
E2E_Evaluator_pre_commit_hooks |
513845.18592587684 ns/iter |
487823.09420791926 ns/iter |
1.05 |
E2E_Evaluator_pulumi |
799693.4237485406 ns/iter |
778590.3522221815 ns/iter |
1.03 |
E2E_Evaluator_semantic_release |
91754.78205462644 ns/iter |
91210.61399843136 ns/iter |
1.01 |
E2E_Evaluator_stale |
172992.84112844992 ns/iter |
171183.09217265263 ns/iter |
1.01 |
E2E_Evaluator_stylecop |
306149.8487246552 ns/iter |
308385.64148464537 ns/iter |
0.99 |
E2E_Evaluator_tmuxinator |
96326.30884184518 ns/iter |
96250.80751301705 ns/iter |
1.00 |
E2E_Evaluator_ui5 |
562463.877207136 ns/iter |
559816.1834936668 ns/iter |
1.00 |
E2E_Evaluator_ui5_manifest |
4456104.382166338 ns/iter |
2931125.045454957 ns/iter |
1.52 |
E2E_Evaluator_unreal_engine_uproject |
482054.0791809252 ns/iter |
481232.2806407126 ns/iter |
1.00 |
E2E_Evaluator_users_array |
766050.6008631346 ns/iter |
690146.331637646 ns/iter |
1.11 |
E2E_Evaluator_vercel |
290935.3460600373 ns/iter |
295296.329966277 ns/iter |
0.99 |
E2E_Evaluator_yamllint |
11966.70573941451 ns/iter |
12023.727513547286 ns/iter |
1.00 |
Schema_Format_ISO_Language_To_JSON |
120663849.16666569 ns/iter |
113698241.00002764 ns/iter |
1.06 |
Schema_Bundle_Meta_2020_12 |
1746231.777232343 ns/iter |
1699022.2257267376 ns/iter |
1.03 |
Schema_Frame_WoT_References |
5313227.969465779 ns/iter |
5213553.246269147 ns/iter |
1.02 |
Schema_Frame_OMC_References |
24877181.428572774 ns/iter |
22369431.354835827 ns/iter |
1.11 |
Schema_Frame_OMC_Locations |
23151868.032263953 ns/iter |
20916949.205885056 ns/iter |
1.11 |
Schema_Frame_ISO_Language_Locations |
110418575.66666143 ns/iter |
105466792.7142938 ns/iter |
1.05 |
Schema_Frame_KrakenD_References |
47273062.1333388 ns/iter |
40090010.47058839 ns/iter |
1.18 |
Schema_Frame_KrakenD_Reachable |
626384991.9998847 ns/iter |
568379995.999976 ns/iter |
1.10 |
Schema_Frame_ISO_Language_Locations_To_JSON |
185488495.9999481 ns/iter |
184863971.2500244 ns/iter |
1.00 |
Schema_Frame_Many_Resources_References |
391311799.00005007 ns/iter |
375571723.500002 ns/iter |
1.04 |
Schema_Iterator_ISO_Language |
3844394.1722221095 ns/iter |
3707890.6772489133 ns/iter |
1.04 |
Schema_Tracker_ISO_Language |
5787244.822580496 ns/iter |
5163511.985185525 ns/iter |
1.12 |
Schema_Tracker_ISO_Language_To_JSON |
26805023.307693217 ns/iter |
26786871.153848764 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
JavaScript (linux/gcc)
Details
| Benchmark suite | Current: 471e684 | Previous: b1d768c | Ratio |
|---|---|---|---|
E2E_Evaluator_adaptivecard |
118269 ns |
117635 ns |
1.01 |
E2E_Evaluator_ansible-meta |
550451 ns |
556003 ns |
0.99 |
E2E_Evaluator_aws-cdk |
131384 ns |
126995 ns |
1.03 |
E2E_Evaluator_babelrc |
377234 ns |
332677 ns |
1.13 |
E2E_Evaluator_cerebrum-criminal-case |
2864086 ns |
2625058 ns |
1.09 |
E2E_Evaluator_clang-format |
286234 ns |
264415 ns |
1.08 |
E2E_Evaluator_cmake-presets |
19269574 ns |
18288199 ns |
1.05 |
E2E_Evaluator_code-climate |
510488 ns |
515727 ns |
0.99 |
E2E_Evaluator_cql2 |
1250230 ns |
1326262 ns |
0.94 |
E2E_Evaluator_cspell |
1738095 ns |
1635225 ns |
1.06 |
E2E_Evaluator_cypress |
856995 ns |
831827 ns |
1.03 |
E2E_Evaluator_deno |
1120372 ns |
1072501 ns |
1.04 |
E2E_Evaluator_dependabot |
1143715 ns |
1090100 ns |
1.05 |
E2E_Evaluator_draft-04 |
23842431 ns |
20910887 ns |
1.14 |
E2E_Evaluator_fabric-mod |
2547410 ns |
2386854 ns |
1.07 |
E2E_Evaluator_geojson |
26618890 ns |
24396705 ns |
1.09 |
E2E_Evaluator_gitpod-configuration |
740028 ns |
710087 ns |
1.04 |
E2E_Evaluator_helm-chart-lock |
1007935 ns |
1001308 ns |
1.01 |
E2E_Evaluator_importmap |
269064 ns |
260138 ns |
1.03 |
E2E_Evaluator_jasmine |
282607 ns |
279997 ns |
1.01 |
E2E_Evaluator_jsconfig |
1511363 ns |
1420015 ns |
1.06 |
E2E_Evaluator_jshintrc |
2952102 ns |
2840484 ns |
1.04 |
E2E_Evaluator_krakend |
638489 ns |
639056 ns |
1.00 |
E2E_Evaluator_lazygit |
481485 ns |
463891 ns |
1.04 |
E2E_Evaluator_lerna |
468067 ns |
444818 ns |
1.05 |
E2E_Evaluator_nest-cli |
613514 ns |
595724 ns |
1.03 |
E2E_Evaluator_omc |
95529 ns |
95087 ns |
1.00 |
E2E_Evaluator_omnisharp |
1485984 ns |
1457166 ns |
1.02 |
E2E_Evaluator_openapi |
25803264 ns |
24021263 ns |
1.07 |
E2E_Evaluator_pre-commit-hooks |
2087365 ns |
2000083 ns |
1.04 |
E2E_Evaluator_pulumi |
2040357 ns |
1978786 ns |
1.03 |
E2E_Evaluator_semantic-release |
232025 ns |
220980 ns |
1.05 |
E2E_Evaluator_stale |
387027 ns |
374656 ns |
1.03 |
E2E_Evaluator_stylecop |
1251622 ns |
1182072 ns |
1.06 |
E2E_Evaluator_tmuxinator |
225264 ns |
222223 ns |
1.01 |
E2E_Evaluator_ui5 |
2179230 ns |
2209310 ns |
0.99 |
E2E_Evaluator_ui5-manifest |
10815922 ns |
10134989 ns |
1.07 |
E2E_Evaluator_unreal-engine-uproject |
1751723 ns |
1598406 ns |
1.10 |
E2E_Evaluator_users-array |
3117760 ns |
2940032 ns |
1.06 |
E2E_Evaluator_vercel |
996821 ns |
1005891 ns |
0.99 |
E2E_Evaluator_yamllint |
24154 ns |
24309 ns |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com