Repository navigation
Conversation
TheRedDaemon
requested changes
Oct 11, 2026
| { | ||
| ++this->missionNumber1to20; | ||
| MACRO_CALL_MEMBER(GameCore_Func::removeLadyAndJester, this)(); | ||
| if (!this->unlockAllHistoricalCampaigns && this->missionNumber1to20 > (int)this->furthestMission) { |
Contributor
There was a problem hiding this comment.
You can check other usages in Ghirda. If this compares as int or rather never as uint, maybe it is an int?
| void GameCore::removeJesterAndLadyUnitsInCertainMissions() | ||
| { | ||
| if (this->missionNumber1to20 < 7) { | ||
| DAT_GameState::instance.mapAndTime.unitJesterRelated = 0; |
Contributor
There was a problem hiding this comment.
I assume this is a jesterActive flag, then?
Or it is the flag indicating that a jester is present. Depends if this prevents it from spawing or if it follows the spawning, so to say.
| } | ||
|
|
||
| if (this->missionNumber1to20 < 11) { | ||
| DAT_GameState::instance.mapAndTime.unitLadyRelated = 0; |
Contributor
There was a problem hiding this comment.
Same as the jester case: A flag indicating if active?
|
|
||
| // FUNCTION: STRONGHOLDCRUSADER 0x0046B2F0 | ||
| void GameCore::setViewOnExitUnk() { this->currentMenuViewType = (MenuViewType)2; } | ||
| void GameCore::setViewOnExitUnk() { this->currentMenuViewType = 2; } |
Contributor
There was a problem hiding this comment.
Is this a enum constant we already have?
Contributor
Author
There was a problem hiding this comment.
No it is an unknown/undefinable one. Added it as UNKNOWN_2
| { | ||
| if (this->buildmenuMenuTabToSwitchTo.tabType == OpenSHC::UI::Enums::BASMTT_SIEGETENT_SHIELD) { | ||
| this->buildmenuMenuTabToSwitchTo.tabType = OpenSHC::UI::Enums::BASMTT_SIEGETENT_BATTERINGRAM; | ||
| if (this->buildmenuMenuTabToSwitchTo.buildMenuTab == 62) { |
Contributor
There was a problem hiding this comment.
Do we have enums for these tabs?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
100% (
setupVolumeAndSoundIDWithMultiplierin src/OpenSHC/Audio/mss/SoundSystem.func.hpp needs to be set to reimplemented for the tail jmp to compare nicely)Found an oddity earlier on : some function bodies use
thisandDAT_GameCore::instance. replacing withthisreduces match.