Repository navigation
Update DOM Expressions to 0.40.12 - #3873
Merged
Merged
Conversation
SSR validates dynamic attribute and tag names, and escapes class and style names (ryansolid/dom-expressions#592). The lockfile is refreshed for 0.40.12, which also updates the stale babel-preset-solid solid-js peer entry left by the 1.9.16 release. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: da5c337 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up dom-expressions 0.40.12 (ryansolid/dom-expressions#592): SSR validates dynamic attribute and tag names, dropping spread keys the HTML parser would read as more than one name and throwing for an invalid tag name (as client
document.createElementdoes, e.g. via<Dynamic component="...">), and escapes class and style names (plusssrSpreadclass values) so a quote cannot end the quoted attribute. Output for valid names is unchanged.dom-expressions,hyper-dom-expressionsandlit-dom-expressionsgo from0.40.11to0.40.12.babel-plugin-jsx-dom-expressionswas not republished (it stays at0.40.11), sobabel-preset-solidis unchanged.babel-preset-solidsolid-jspeer entry left by the 1.9.16 release (^1.9.15→^1.9.16) and prunes unusedseroval1.5.x entries;pnpm install --frozen-lockfilepasses again.solid-jspatch.pnpm run buildpasses;solid-jsclient (487) and server (8) tests,test-typesandbabel-preset-solidtests all pass. The builtweb/dist/server.js/server.cjsdrop invalid spread keys, escapessrSpreadclass values, throw for an invalid<Dynamic>tag name, and render valid names exactly as before.Prepared with Claude via Cursor