Conversation
Reword 'And also apply when attempting use any transformation' to
'They also apply when attempting to use any transformation':
- 'And' starting a sentence was ungrammatical; 'They' refers back
to 'differences from Solid's JSX' (the actual subject).
- 'attempting use' was missing the infinitive 'to'.
Single-line docs-only change in packages/solid/h/README.md.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a grammar issue in the HyperScript README.
The sentence:
has two problems:
And also applystarts a new sentence with a coordinating conjunction and lacks a subject —They also apply(referring back todifferences) is the intended reading.attempting useis missing the infinitiveto— should beattempting to use.Reworded to:
This is a docs-only, single-line change to
packages/solid/h/README.md(no code, no tests).How tested
packages/solid/h/README.mdis changed (git diff).attempting useexist in the repo (rg "attempting use"returns just this one hit).gh search prs repo:solidjs/solid "attempting use"→ 0 results).Happy to rebase / rename / split if maintainers prefer a different commit message or scope.