feat(@typegpu/three): t3.attribute as a shorthand for t3.fromTSL(TSL.attribute('...', 'type'), d.type)

[iwoplaza]

No description provided.

[github-actions]

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@9d393ca14995eda7bce19bb90375f9751ac16351

https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/three@9d393ca14995eda7bce19bb90375f9751ac16351

benchmark
view benchmark

commit
view commit

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a typed t3.attribute helper to simplify creating Three.js TSL attribute nodes from TypeGPU schemas, and updates docs/examples to use it.

Changes:

• Introduced attribute() helper in @typegpu/three and exported it from the package entrypoint.
• Added a Vitest test to verify WGSL schema → TSL node type mapping.
• Updated docs and example apps to use t3.attribute instead of manual fromTSL(TSL.attribute(...), ...).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/typegpu-three/tests/attribute.test.ts	Adds parameterized tests validating schema → TSL nodeType mapping and attribute name wiring.
packages/typegpu-three/src/attribute.ts	Implements the new attribute() helper around three/tsl + fromTSL.
packages/typegpu-three/src/index.ts	Exports attribute from the package barrel.
packages/typegpu-three/src/uniform.ts	Aligns d import style with other code (import { d } from 'typegpu').
apps/typegpu-docs/src/examples/threejs/simple/index.ts	Migrates example to t3.attribute.
apps/typegpu-docs/src/examples/threejs/compute-cloth/index.ts	Migrates example to t3.attribute.
apps/typegpu-docs/src/content/docs/ecosystem/typegpu-three/index.mdx	Documents t3.attribute and clarifies equivalence with manual fromTSL(TSL.attribute(...)).

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Bundle size comparison (import * as ... in PR vs import * as ... in target):

🟢 Decreased	➖ Unchanged	🔴 Increased (max 0.55%)	❔ Unknown
0	198	126	1

import * as ... in PR vs import * as ... in target (did bundle size increase?):

Click to reveal the results table (62 entries).

Test	tsdown
std_dot.ts	69.67 kB ($${\color{red}+0.5\%}$$)
std_length.ts	69.67 kB ($${\color{red}+0.5\%}$$)
std_distance.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_dot4U8Packed.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_fract.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_frexp.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_mix.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_modf.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_abs.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_acos.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_acosh.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_asin.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_asinh.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_atan.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_atan2.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_atanh.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_ceil.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_clamp.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_cos.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_cosh.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_countLeadingZeros.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_countOneBits.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_countTrailingZeros.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_cross.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_degrees.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_determinant.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_dot4I8Packed.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_exp.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_exp2.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_extractBits.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_faceForward.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_firstLeadingBit.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_firstTrailingBit.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_floor.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_fma.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_insertBits.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_inverseSqrt.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_ldexp.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_log.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_log2.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_max.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_min.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_normalize.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_pow.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_quantizeToF16.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_radians.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_reflect.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_refract.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_reverseBits.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_round.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_saturate.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_sign.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_sin.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_sinh.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_smoothstep.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_sqrt.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_step.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_tan.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_tanh.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_transpose.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_trunc.ts	69.68 kB ($${\color{red}+0.5\%}$$)
std_intdiv.ts	69.68 kB

import { ... } in PR vs import * as ... in PR (is the library tree-Shakeable?):

Test	tsdown
tgpu_init.ts	274.89 kB ($${\color{green}-3.4\%}$$)
tgpu_initFromDevice.ts	274.35 kB ($${\color{green}-3.5\%}$$)
tgpu_resolve.ts	175.18 kB ($${\color{green}-38.4\%}$$)
tgpu_resolveWithContext.ts	175.12 kB ($${\color{green}-38.4\%}$$)
tgpu_bindGroupLayout.ts	74.49 kB ($${\color{green}-73.8\%}$$)
tgpu_mutableAccessor.ts	69.21 kB ($${\color{green}-75.7\%}$$)
tgpu_accessor.ts	69.21 kB ($${\color{green}-75.7\%}$$)
tgpu_privateVar.ts	67.90 kB ($${\color{green}-76.1\%}$$)
tgpu_workgroupVar.ts	67.90 kB ($${\color{green}-76.1\%}$$)
tgpu_const.ts	67.32 kB ($${\color{green}-76.3\%}$$)
tgpu_lazy.ts	67.12 kB ($${\color{green}-76.4\%}$$)
tgpu_fragmentFn.ts	39.65 kB ($${\color{green}-86.1\%}$$)
tgpu_fn.ts	39.60 kB ($${\color{green}-86.1\%}$$)
tgpu_vertexFn.ts	39.47 kB ($${\color{green}-86.1\%}$$)
tgpu_computeFn.ts	39.17 kB ($${\color{green}-86.2\%}$$)
tgpu_vertexLayout.ts	28.30 kB ($${\color{green}-90.1\%}$$)
tgpu_comptime.ts	15.91 kB ($${\color{green}-94.4\%}$$)
tgpu_unroll.ts	1.75 kB ($${\color{green}-99.4\%}$$)
tgpu_slot.ts	1.70 kB ($${\color{green}-99.4\%}$$)

If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.

[github-actions]

Resolution Time Benchmark

---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [1.00, 2.15, 4.36, 7.32, 8.63, 15.51, 25.54, 28.35]
  line [1.04, 2.10, 4.41, 6.70, 7.94, 12.74, 25.80, 27.33]
  line [1.04, 2.14, 4.67, 7.26, 9.04, 11.89, 26.48, 27.79]

Loading

---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.30, 0.54, 0.71, 0.89, 1.23, 1.23, 1.51, 1.67]
  line [0.37, 0.60, 0.72, 0.86, 1.19, 1.28, 1.51, 1.68]
  line [0.36, 0.57, 0.78, 0.89, 1.25, 1.34, 1.61, 1.73]

Loading

---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [1.15, 2.61, 4.25, 8.33, 14.14, 28.07, 58.99, 122.59]
  line [0.96, 2.38, 4.19, 7.71, 13.03, 27.32, 58.59, 120.42]
  line [0.94, 2.48, 4.53, 7.79, 14.42, 29.08, 61.09, 124.22]

Loading

[pullfrog]

Important

The new t3.attribute API can silently build a float-typed attribute node (plus a startup console warning) for TypeGPU schemas that aren't in wgslTypeToGlslType.

Reviewed changes

• attribute.ts — new t3.attribute(name, dataType) shorthand that maps a TypeGPU schema to a GLSL type and wraps it via fromTSL(TSL.attribute(name, glslType), dataType); exported from index.ts.
• uniform.ts — normalizes the d import to the typegpu root (matching instancedArray.ts); no behavior change.
• Examples threejs/simple and threejs/compute-cloth — migrated attribute accessors from t3.fromTSL(TSL.attribute(...), ...) to t3.attribute(...); TSL import dropped where unused.
• Docs — new t3.attribute and t3.uniform sections on the @typegpu/three page, with twoslash snippets.
• Tests — new parameterized attribute.test.ts asserting GLSL-type mapping and attribute name for 6 scalar/vector schemas.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏}

[pullfrog]

wgslTypeToGlslType has no entries for bool, f16/half-precision vectors, vec*b, or matrices, so passing any such schema yields glslType === undefined. TSL.attribute(name, undefined) then keeps a struct with no declared type, and fromTSL resolves it to 'float' against its geometry-less sharedBuilder — verified at runtime: t3.attribute('x', d.bool), d.f16, d.vec3h, and d.mat4x4f each emit Suspected type mismatch between TSL type 'f32' ... and TypeGPU type ... at create-time and produce a float-typed node. For a real half-float attribute this is a silently wrong vertex attribute, not an error. This also undercuts the docs claim that the TSL node type is "inferred from the TypeGPU schema" (index.mdx:127-128).

[pullfrog]

Suggested fix: restrict TDataType to the mapped type union (d.F32 | d.U32 | d.I32 | d.Vec2f | d.Vec2u | d.Vec2i | d.Vec3f | d.Vec3u | d.Vec3i | d.Vec4f | d.Vec4u | d.Vec4i), so unmappable schemas become a compile-time error instead of a runtime warning plus a mis-typed node. If broader support is intended, handle the undefined case explicitly (as uniform does) and document which schemas are supported; add a test pinning the rejected cases either way.