SK-3024-gitleaks-detection-multiple-secret-exposures-identified - #157
Open
skyflow-bharti wants to merge 1 commit into
Open
SK-3024-gitleaks-detection-multiple-secret-exposures-identified#157skyflow-bharti wants to merge 1 commit into
skyflow-bharti wants to merge 1 commit into
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep findings: No issues found, Good to merge. |
This was referenced Aug 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The security team's Gitleaks scan flagged two generic-api-key findings in README.md (lines 1835, 1841) — sample UUID-format token IDs in the "Sample Response" documentation block that happen to match the secret-detection pattern. These are illustrative example values from API response docs, not real credentials, but the findings need to be resolved to close out the security review.
Goal:
Suppress the two false-positive findings without altering the visible README content (so SDK consumers still see the real, realistic sample response), by adding a .gitleaksignore file with fingerprints for the two specific findings — Gitleaks' native, built-in suppression mechanism for exactly this case.