Repository navigation
schema: declare the sensors-* keys the sensors plugin reads - #267
Merged
mirkobrombin merged 1 commit intoOct 14, 2026
Merged
Conversation
The sensors plugin reads sensors-interval-seconds, sensors-show-frequency, sensors-show-utilization, sensors-grouped, sensors-gpu-zone and sensors-cpu-zone behind has_key(), but the schema never declared them, so they could not be set. Defaults match the plugin built-in values. Assisted-by: Claude Code:claude-sonnet-5-5 AI-Scope: Wrote the six key declarations from the keys and defaults the sensors plugin reads, and checked them with a strict schema compile.
Member
|
Good, these were unreachable from gsettings. Merging as squash with a fix: subject, schema: is not one of our commit types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sensors plugin reads
sensors-interval-seconds,sensors-show-frequency,sensors-show-utilization,sensors-grouped,sensors-gpu-zoneandsensors-cpu-zonebehindhas_key(), but the schema never declared them. They always fall through to the plugin's built-in values and cannot be set with gsettings or dconf.Change
Declares the six keys with the plugin's own defaults (2 seconds, true, true, true, empty, empty). The interval is limited to 1-60. Nothing else changes.
Verification
glib-compile-schemas --strictpasses.gsettings getreturns the defaults above for all six keys, and an interval of 0 is rejected as out of range.meson setup && ninja784/784 targets,meson test25/25 pass.Not verified
AI assistance: disclosed