Moves private token from the params to the header#54
Open
atttiwari wants to merge 4 commits into
Open
Conversation
atttiwari
force-pushed
the
SAC-31453-params-to-header
branch
2 times, most recently
from
af62ffe to
fb5adf6
Compare
atttiwari
force-pushed
the
SAC-31453-params-to-header
branch
from
fb5adf6 to
0e323ca
Compare
RushiT0122
approved these changes
Jul 3, 2026
atttiwari
force-pushed
the
SAC-31453-params-to-header
branch
from
f1b9ba8 to
b8c090b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
PR include fix involves two changes: update
authenticateto pass the token viaPRIVATE-TOKENheader instead of params, and simplifycheck_api_credentialsto reuse authenticate. SAC-31453Updated the exception handling in tap_gitlab/exceptions.py. Improved error parsing to surface the actual GitLab error message when available. Retained the fallback behavior only when no meaningful error message can be extracted from the response. SAC-31205
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code