Repository navigation
Use NumPy bit packing for Fit2D masks - #686
Merged
Merged
Conversation
kif
approved these changes
Nov 16, 2026
kif
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Thanks for the work done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the per-bit loops with NumPy's
packbits/unpackbits, preserving little-endian bit order, 32-bit row padding, and zero/nonzero mask values. Add independent byte-level checks for padding, bit order, strided input, and compressed files.On Windows/Python 3.13 with NumPy 2.5.4, a 2048×2048 mask reads about 10× faster and writes about 3.3× faster (14 interleaved samples per implementation, including file I/O, identical output bytes).
Closes #216.