Remove a couple null-forgiving operators in MachineApiService - #4105
Merged
Merged
Conversation
marksvc
marked this pull request as draft
September 14, 2026 22:47
marksvc
marked this pull request as ready for review
September 14, 2026 22:51
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4105 +/- ##
==========================================
- Coverage 80.95% 80.95% -0.01%
==========================================
Files 664 664
Lines 42153 42153
Branches 6944 6939 -5
==========================================
- Hits 34126 34125 -1
Misses 6864 6864
- Partials 1163 1164 +1 ☔ View full report in Codecov by Harness. |
Contributor
|
📸 Screenshot diff deployed! (1 change) View the visual diff at: https://pr-4105--sf-screenshot-diffs.netlify.app |
pmachapman
approved these changes
Sep 14, 2026
pmachapman
left a comment
pmachapman
left a comment
Collaborator
There was a problem hiding this comment.
@pmachapman reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on marksvc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch proposes a couple null-related adjustments in followup to #4025.
Open in Devin Review
This change is