style: match Chunk into Resources dialog to the Add Audio Resource mock - #595
Draft
nabalone wants to merge 1 commit into
Draft
style: match Chunk into Resources dialog to the Add Audio Resource mock#595nabalone wants to merge 1 commit into
nabalone wants to merge 1 commit into
Conversation
- Title now mirrors the previous step's dialog (Add/Edit Audio Resource) instead of "Chunk into Resources". - Stripe the segment table's rows (theme.palette.action.hover, as KeyTermTable does) and keep every cell's text at the normal color, including the header and the read-only Reference column. - Move the Suffix field below the table with a blue info tooltip icon, and pin Copy to clipboard to the bottom-left, matching the mock. - Let the waveform and table span the full dialog width. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new tooltip help icon is not keyboard-accessible and the wizard section contains duplicate DOM ids, both of which should be corrected before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Restyles the Chunk into Resources wizard (ProjectResourceConfigure) UI to align with the Add/Edit Audio Resource dialog patterns in the Passage Detail artifacts workflow.
Changes:
- Updated the project resource wizard dialog title to reflect Add Audio Resource vs Edit Audio Resource based on entry path.
- Made the segment table full-width with a flexible Description column and added striped rows consistent with existing table striping.
- Repositioned the Suffix field below the table with an info tooltip icon, and pinned Copy to clipboard to the left of the action row.
File summaries
| File | Description |
|---|---|
| src/renderer/src/components/PassageDetail/Internalization/ProjectResourceConfigure.tsx | Full-width datasheet + striped rows; moves Suffix UI and action-row layout. |
| src/renderer/src/components/PassageDetail/Internalization/PassageDetailArtifacts.tsx | Aligns wizard dialog title with Add/Edit Audio Resource flow and adjusts wizard width. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
586
to
587
| <StyledPaper id="proj-res-sheet" style={heightStyle}> | ||
| <StyledTable id="proj-res-sheet"> |
Comment on lines
608
to
610
| <LightTooltip title={t.suffixTip}> | ||
| <TextField | ||
| label={t.suffix} | ||
| variant="outlined" | ||
| value={suffix} | ||
| onChange={handleSuffix} | ||
| /> | ||
| <InfoIcon color="info" fontSize="small" /> | ||
| </LightTooltip> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restyles the Chunk into Resources wizard (
ProjectResourceConfigure) to match the Add Audio Resource mock.Changes
theme.palette.action.hover, the same approachKeyTermTableuses. Every cell's text stays the normal color (header and the read-only Reference column included) — react-datasheet's grey read-only tint is cleared so rows stripe uniformly.Waveform controls were left as the existing
PassageDetailPlayer/WSAudioPlayerbuilt-ins (nothing new built).Notes
internalize_changes_part2(the base branch these files already diverge from develop on).npm run typecheck:webpasses;ProjectResourceConfigurejest suite passes.🤖 Generated with Claude Code