Repository navigation
fix: install the rustls aws-lc-rs crypto provider at startup - #1355
Conversation
The rust-libp2p update in v1.4.0 enables rustls' aws-lc-rs backend (through libp2p-quic) alongside ring. With both compiled in, rustls cannot choose a process-wide default and panics when the execution-layer websocket opens a TLS connection, so nodes using a wss:// endpoint crash at startup. Install ring explicitly, the backend used before.
Match Lighthouse, which installs aws-lc-rs as the process-wide default.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #1355 +/- ##
=========================================
Coverage 81.21% 81.21%
=========================================
Files 180 180
Lines 41831 41834 +3
=========================================
+ Hits 33973 33976 +3
Misses 7858 7858
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Queued — the merge queue status continues in this comment ↓. |
Merge Queue Status
This pull request spent 29 minutes 59 seconds in the queue, including 27 minutes 31 seconds running CI. ReasonPull request #1355 has been dequeued GitHub refused to merge the pull request. Repository rule violations found
HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. Required conditions to merge
Tick the box to put this pull request back in the merge queue (same as
|
Problem, Evidence, and Context
wss://execution endpoint:Could not automatically determine the process-level CryptoProvider from Rustls crate features.aws-lc-rsbackend (through libp2p-quic) alongsidering, so rustls can no longer pick a default.Change Overview
aws-lc-rsas the rustls crypto provider at startup.Validation
wss://endpoint: v1.4.0 panics in the event syncer; this branch connects and starts historical sync.make cargo-fmt-check,make lint,make testpass.Rollback