Repository navigation
fix(message_validator): reject signers outside the committee - #1351
Merged
mergify[bot] merged 1 commit intoOct 22, 2026
Merged
Conversation
Signers were added to the per-duty state before anything checked that they belong to the message's committee, so a peer could list made-up operator ids and grow that state without valid signatures. Reject such messages with SignerNotInCommittee before signers are added to the duty state, matching go-ssv's committee membership check.
|
Queued — the merge queue status continues in this comment ↓. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## epbs #1351 +/- ##
==========================================
+ Coverage 80.88% 81.21% +0.32%
==========================================
Files 179 180 +1
Lines 41247 41831 +584
==========================================
+ Hits 33364 33973 +609
+ Misses 7883 7858 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merge Queue Status
This pull request spent 29 minutes 43 seconds in the queue, including 27 minutes 20 seconds running CI. Required conditions to merge
|
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem, Evidence, and Context
ErrSignerNotInCommittee. Anchor already hasSignerNotInCommitteebut never returned it.Change Overview
SignerNotInCommittee(Reject), before signers are added to the duty state. This covers consensus and partial-signature messages.Risks, Trade-offs, and Mitigations
Validation
SignerNotInCommitteeand leaves the duty state empty. Without the fix it fails on both checks.make cargo-fmt-check,make lint,make testpass.Rollback