Repository navigation
fix(ssv_types): accept pre-Gloas aggregator versions that share a decode shape - #1326
Merged
Merged
Conversation
…ode shape Anchor labels a Fulu-slot aggregate Electra while go-ssv labels it Fulu, so the raw label equality added in sigp#1215 rejected every go-ssv-led pre-Boole aggregator round in mixed clusters. Bind the leader's label to the decode shape of the fork scheduled at the duty slot instead, which accepts both labels before Gloas and still requires Gloas at Gloas slots (SIP-94 section 2).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## epbs #1326 +/- ##
=======================================
Coverage ? 80.83%
=======================================
Files ? 179
Lines ? 41321
Branches ? 0
=======================================
Hits ? 33400
Misses ? 7921
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Review from Claude Opus 5.5 (effort: high) No findings.
Not independently verified: the ssv-mini mixed-cluster results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem, Evidence, and Context
In a mixed cluster (2 Anchor + 2 go-ssv, Fulu, SSV Boole fork not active), Anchor rejected every per-validator aggregator value led by go-ssv with
wrong data version: expected fork Electra, got Fulu. The two clients label the same Electra-shaped aggregate differently: Anchor labels itElectra(the shape's representative fork) and go-ssv labels itFulu(the beacon node's version). Since #1215, the aggregator check has required the leader's label to equal our own. With both Anchors rejecting, the cluster could not reach quorum and waited for a round change. In a local ssv-mini run this hit slots 71, 75, 83, 95, 99, 102, 103, 126 and 127, every pre-Gloas aggregate with a go-ssv round-1 leader. Slot 71 was published at +10.0s instead of about +8s. No errors occurred after the Gloas fork.This affects any network running
epbswith Boole not active before Gloas, for example Sepolia mixed clusters until Sepolia's Gloas fork.unstablehas no such check, so mainnet is unaffected.Change Overview
The aggregator check now compares decode shapes. The leader's label must select the same shape as the fork scheduled at the duty slot, the same reference the proposer check already uses. Electra and Fulu both select the Electra shape, so both labels are accepted before Gloas. At Gloas slots only
Gloasis accepted, so the SIP-94 §2 rule still holds: a leader cannot make the cluster decode a Gloas aggregate as Electra and sign the old signing root. A rejection now reports the scheduled fork (expected Fulu) instead of our own label.Intentionally unchanged:
Electra. go-ssv accepts that label, and Lighthouse parses anelectraheader on a Fulu slot as the same type. In the same run, go-ssv submitted all 8 Anchor-led pre-Gloas aggregates without a failure.Risks, Trade-offs, and Mitigations
The check now accepts every label that shares the scheduled fork's shape. Only Electra and Fulu labels can differ this way on live networks, and the decoder already treats them as one shape. The only other behavior change: a
Hezelabel now fails as an unsupported fork instead of as a version mismatch. It is still rejected.Validation
FuluandElectralabels are both accepted, whichever label our own value carries. On a Gloas slot,FuluandElectralabels are rejected even when our own value is labelledElectra, while the same bytes labelledGloasare accepted. On a Fulu slot, aDeneblabel is rejected.Denebrejection test passes both before and after, because it covers behavior both versions share.cargo test -p ssv_types --release: 140 passed, plus 2 doc-tests.make cargo-fmt-checkandmake lint: passed.Rollback
Revert the commit. No configuration or data migration is required.