Fix Screen Lock authentication while device is locked - #6326
Open
JustAlex0000 wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi, thanks for your interest in contributing. I'm not able to reproduce the issue you're describing; when I lock the device (with Always-On Display enabled) with Signal foregrounded and Signal Screen Lock enabled, I simply see the device lock. Pressing the power button to then wake the device causes it to use FaceID to unlock (as normal), and when I then swipe the Lock Screen away and Signal is again foregrounded it goes through the Signal Screen Lock (as normal). Could I ask you for a screen recording of the issue you're experiencing, so I can make sure we're talking about the same things? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Contributor checklist
Administrative:
Commits and testing:
Description
When Signal is open on an iPhone with Always-On Display enabled, locking the phone causes Signal's Face ID prompt to appear on the Lock Screen. After unlocking the phone, Signal asks for Face ID again.
This change prevents Signal from starting Screen Lock authentication while the device is locked. Once the device is unlocked, Signal checks the Screen Lock state again and presents authentication normally.
Testing