prefs: add 12/24-hour time format preference - #8017
Open
yzhou216 wants to merge 1 commit into
Open
Conversation
Add a "Time format" setting with two options (Default 24-hour and 12-hour) that the renderer resolves for message timestamps. On non-Darwin platforms the default resolves to 24-hour, since Electron exposes no OS time-format API there, while Darwin keeps reading the OS time-format toggle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
Add a "Time format" setting with two options (Default 24-hour and 12-hour) that
the renderer resolves for message timestamps. On non-Darwin platforms the
default resolves to 24-hour, since Electron exposes no OS time-format API there,
while Darwin keeps reading the OS time-format toggle.