Sticker search: try to compare unknown emojis - #8010
Open
eth0fox wants to merge 1 commit into
Open
Conversation
This was referenced Sep 1, 2026
When a user uses the sticker search, we now normalise the relevant emojis from our list, and the sticker's emoji before comparing. We do this because sometimes, the variation selector character's presence defined in a sticker pack differs from what Signal has defined in it's list of emojis, and doing a strict comparison will result in that sticker not being able to be searched for Fixes signalapp#8009
eth0fox
force-pushed
the
loose-sticker-emoji-search
branch
from
September 4, 2026 17:36
24436ec to
333e14f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
If the emoji byte sequence does not exactly match one of the emojis defined in Signal's emoji list, we try and do a
localeCompareto the found emojis instead of returning false.We do this because sometimes, the variation selector character's presence differs from what is defined in a sticker pack, and doing a strict comparison will result in that sticker not being able to be searched for
Fixes #8009
This change implements a divergence in behaviour from Signal Android & iOS clients, however, I think it would be best to resolve this issue in those clients too.