Resolves #14206 A11y conversation list - #14990
Open
s4p3r-c1n0s wants to merge 11 commits into
Open
Conversation
s4p3r-c1n0s
force-pushed
the
a11y-conversation-list
branch
from
September 4, 2026 07:16
8d9c38e to
ecdb419
Compare
…rsation list only
s4p3r-c1n0s
force-pushed
the
a11y-conversation-list
branch
from
September 4, 2026 07:19
ecdb419 to
4f181da
Compare
s4p3r-c1n0s
marked this pull request as ready for review
September 4, 2026 07:19
Author
|
@mtang-signal can you help review this |
- Fix bug where UNARCHIVE action was calling handleArchive() instead of handleUnarchive() - Add test to verify archived conversations can be unarchived via accessibility action - Ensures TalkBack users can properly unarchive conversations
Extract action-label and action-dispatch logic into ConversationListAccessibilityHelper to avoid duplication between ConversationListAdapter and ConversationListSearchModels. - New ConversationListAccessibilityHelper.kt with two methods: * addConversationActions() - populates accessibility node with applicable actions * dispatchConversationAction() - routes action ID to appropriate handler - Simplify ConversationListAdapter by delegating to helper - Centralized policy ensures consistency across all conversation list views
Use the single stable action ID conversation_list_accessibility_archive_action instead of non-existent conversation_list_accessibility_unarchive_action. The production code uses one stable ID and toggles the label/action based on conversation state: - Unarchived row: label='Archive', action archives - Archived row: label='Unarchive', action unarchives Test now correctly verifies the label shows 'Unarchive' for archived rows and that performing the action actually unarchives the conversation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxNOTE : this is Part I of the closed PR #14612 focusing only on Conversations List (chat list)
Description
add chat-list accessibility actions (#14206)
ConversationListFragmenthandlers.ConversationListAdapterAccessibilityActionsInstrumentedTest