Respect explicit stay-connected-in-background opt-out despite FCM failures - #14914
Open
br4yd wants to merge 1 commit into
Open
Respect explicit stay-connected-in-background opt-out despite FCM failures#14914br4yd wants to merge 1 commit into
br4yd wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234syntaxDescription
Fixes #14909
Currently, ForceWebsocketMode.DISABLED is used for two different scenarios:
Because the app can't tell these two states apart, the automatic fallback logic breaks. Normally as far as I understand, if FCM (push notifications) fails for 3+ days, the app automatically enables WebSocket mode as a safety net. But because manual opt-outs look identical to the untouched default, the app keeps re-enabling WebSocket mode in the background even if the user explicitly turned it off. From the user's perspective, the setting just keeps resetting itself.
This showed up in the reporter's logs: FCM failed with FIS_AUTH_ERROR, so the app auto-enabled WebSocket mode. Every time the user turned it off, the next background sync saw DISABLED and immediately flipped it back on.
What this PR changes:
Testing