Skip to content

test(app): quarantine FolderSwitch tab e2e test - #439

Merged
shuv1337 merged 2 commits into
integration-v2from
fm/sc-folderswitch-quarantine
Oct 6, 2026
Merged

shuv1337 merged 2 commits into
integration-v2from
fm/sc-folderswitch-quarantine

Conversation

@shuv1337

@shuv1337 shuv1337 commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Quarantines one app e2e test with test.fixme(): packages/app/e2e/regression/tabs.spec.ts, "each session tab shows its own file tab after a switch to a session in another folder".

The test fails because a span[data-slot=project] showing "FolderSwitch" covers the Open file button, so the click times out (example: https://github.com/shuv1337/shuvcode/actions/runs/37427591275/job/112150819534). That failure blocks unrelated changes.

The test body and its assertions are unchanged. Tracking issue for the UI fix and re-enable: #438

Test infrastructure only. No product or UI changes.

shuv1337 commented Oct 6, 2026

Copy link
Copy Markdown
Owner Author

🔍 Automated Cursor review is underway. Please hold off on merging until the review comment lands here (usually 10–20 minutes).

@cursor

cursor Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review complete:

Medium — packages/app/e2e/regression/tabs.spec.ts:487-489 (underlying UI: packages/app/src/shell/titlebar/tab-popover.css:24, packages/app/src/shell/titlebar/tab-popover.tsx:74-87). The test.fixme() is inside this one test, the assertions are unchanged, and issue #438 is linked, but the failure it silences is a real click trap. In the cited run (job 112150819534) the first Open file click succeeds; the 60s timeout is the next one, open("notes.txt") after the switch to the other-folder session, and it failed on all 3 attempts. The trace snapshot at that click shows the session-tab hover card still open, the switched tab focused, and [data-component=session-tab-popover] positioned at translate3d(553px, 43px, 0px) with inline pointer-events: auto. That inline style overrides the stylesheet's pointer-events: none, so the span[data-slot=project] reading "FolderSwitch" receives the click meant for the review panel's Open file button. At the test's 1440×900 viewport with the review panel open, activating a session tab leaves that preview up over the button. Users in the same layout hit the same overlap. Re-enable work on #438 needs the preview to be click-through, or to close once the pointer leaves the tab.

Low — packages/app/e2e/regression/tabs.spec.ts:489. test.fixme() is called with no description, so the Playwright report will not carry the issue URL; the link exists only in the comment above the call. Passing the #438 URL as the fixme description would keep the quarantine visible in CI output. This is the only test.fixme in the repo; the call itself is the right Playwright API and applies only to this test (the Windows titlebar test below it still runs). The PR text does not auto-close #438.

@shuv1337

shuv1337 commented Oct 6, 2026

Copy link
Copy Markdown
Owner Author

Responses to the Cursor review:

Low (fixme has no description): Fixed in 3da9fdf. The fixme is now test.fixme(true, "FolderSwitch project label covers the Open file button: https://github.com/shuv1337/shuvcode/issues/438"), so the issue URL shows up in the Playwright report.

Medium (real click trap): This PR only quarantines the test; the UI fix is out of scope. I added the root cause to #438: the session-tab hover popover stays open with inline pointer-events: auto after the folder switch, and the failing click is the second open("notes.txt"). The PR text does not close #438 on purpose; the issue stays open until the UI fix lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant