You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(app): quarantine FolderSwitch tab e2e test - #439
Quarantines one app e2e test with test.fixme(): packages/app/e2e/regression/tabs.spec.ts, "each session tab shows its own file tab after a switch to a session in another folder".
Medium — packages/app/e2e/regression/tabs.spec.ts:487-489 (underlying UI: packages/app/src/shell/titlebar/tab-popover.css:24, packages/app/src/shell/titlebar/tab-popover.tsx:74-87). The test.fixme() is inside this one test, the assertions are unchanged, and issue #438 is linked, but the failure it silences is a real click trap. In the cited run (job 112150819534) the first Open file click succeeds; the 60s timeout is the next one, open("notes.txt") after the switch to the other-folder session, and it failed on all 3 attempts. The trace snapshot at that click shows the session-tab hover card still open, the switched tab focused, and [data-component=session-tab-popover] positioned at translate3d(553px, 43px, 0px) with inline pointer-events: auto. That inline style overrides the stylesheet's pointer-events: none, so the span[data-slot=project] reading "FolderSwitch" receives the click meant for the review panel's Open file button. At the test's 1440×900 viewport with the review panel open, activating a session tab leaves that preview up over the button. Users in the same layout hit the same overlap. Re-enable work on #438 needs the preview to be click-through, or to close once the pointer leaves the tab.
Low — packages/app/e2e/regression/tabs.spec.ts:489. test.fixme() is called with no description, so the Playwright report will not carry the issue URL; the link exists only in the comment above the call. Passing the #438 URL as the fixme description would keep the quarantine visible in CI output. This is the only test.fixme in the repo; the call itself is the right Playwright API and applies only to this test (the Windows titlebar test below it still runs). The PR text does not auto-close #438.
Low (fixme has no description): Fixed in 3da9fdf. The fixme is now test.fixme(true, "FolderSwitch project label covers the Open file button: https://github.com/shuv1337/shuvcode/issues/438"), so the issue URL shows up in the Playwright report.
Medium (real click trap): This PR only quarantines the test; the UI fix is out of scope. I added the root cause to #438: the session-tab hover popover stays open with inline pointer-events: auto after the folder switch, and the failing click is the second open("notes.txt"). The PR text does not close #438 on purpose; the issue stays open until the UI fix lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quarantines one app e2e test with
test.fixme():packages/app/e2e/regression/tabs.spec.ts, "each session tab shows its own file tab after a switch to a session in another folder".The test fails because a
span[data-slot=project]showing "FolderSwitch" covers the Open file button, so the click times out (example: https://github.com/shuv1337/shuvcode/actions/runs/37427591275/job/112150819534). That failure blocks unrelated changes.The test body and its assertions are unchanged. Tracking issue for the UI fix and re-enable: #438
Test infrastructure only. No product or UI changes.