Skip to content

Update aws-batch.mdx External ID for Cloud#1511

Merged
justinegeffen merged 22 commits into
masterfrom
MichaelTansiniSeqera-patch-1
Jul 7, 2026
Merged

Update aws-batch.mdx External ID for Cloud#1511
justinegeffen merged 22 commits into
masterfrom
MichaelTansiniSeqera-patch-1

Conversation

@MichaelTansiniSeqera

Copy link
Copy Markdown
Contributor

DRAFT improve external ID

DRAFT improve external ID

Signed-off-by: MichaelTansiniSeqera <michael.tansini@seqera.io>
@netlify

netlify Bot commented Jun 3, 2026

Copy link
Copy Markdown

Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit b1cbc89
🔍 Latest deploy log https://app.netlify.com/projects/seqera-docs/deploys/6a4c13ad420b2c0009af9fc4
😎 Deploy Preview https://deploy-preview-1511--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: MichaelTansiniSeqera <michael.tansini@seqera.io>
Signed-off-by: MichaelTansiniSeqera <michael.tansini@seqera.io>
Signed-off-by: MichaelTansiniSeqera <michael.tansini@seqera.io>
Signed-off-by: MichaelTansiniSeqera <michael.tansini@seqera.io>
Signed-off-by: MichaelTansiniSeqera <michael.tansini@seqera.io>
Signed-off-by: MichaelTansiniSeqera <michael.tansini@seqera.io>
Signed-off-by: MichaelTansiniSeqera <michael.tansini@seqera.io>
Signed-off-by: MichaelTansiniSeqera <michael.tansini@seqera.io>
Signed-off-by: MichaelTansiniSeqera <michael.tansini@seqera.io>
@MichaelTansiniSeqera MichaelTansiniSeqera changed the title Update aws-batch.mdx DRAFT Update aws-batch.mdx External ID for Cloud Jun 3, 2026
@MichaelTansiniSeqera MichaelTansiniSeqera marked this pull request as ready for review June 3, 2026 16:02
@MichaelTansiniSeqera

Copy link
Copy Markdown
Contributor Author

Adding reviewers, specifically @munishchouhan for correctness and @gwright99 for technical clarity

@justinegeffen justinegeffen added the 3. Dev/PM/SME reviews complete SMEs have reviewed and approved. label Jun 8, 2026

@stefanoboriero stefanoboriero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 3 ways AWS credentials can be defined:

  1. With AWS user access keys
  2. With an AWS role and AWS user access keys to be used to assume the role (so the role is still assumed by the customer AWS user)
  3. With an AWS role and externalID + trust policy for the role to be assumed by Seqera jump role

This change effectively removes the documentation of option number 2, driving people who want to user an AWS role towards the externalID option: I wanted to check if this is intentional. Feels a bit off removing documentation for something that is still supported by Platform and not deprecated AFAIK

@justinegeffen justinegeffen added 1. Dev/PM/SME Needs a review by a Dev/PM/SME do not merge Do not merge until this label is removed additional work req. Additional work is required/comments need to be addressed before second review and removed 3. Dev/PM/SME reviews complete SMEs have reviewed and approved. labels Jun 8, 2026
Comment thread platform-cloud/docs/compute-envs/aws-batch.mdx
@MichaelTansiniSeqera

Copy link
Copy Markdown
Contributor Author

With an AWS role and AWS user access keys to be used to assume the role (so the role is still assumed by the customer AWS user)

@stefanoboriero no we should still include this but perhaps put it within its own section to make clear it's a hybrid role - I will amend.

@justinegeffen justinegeffen removed the additional work req. Additional work is required/comments need to be addressed before second review label Jun 26, 2026
@justinegeffen justinegeffen added 2. Edu reviews complete Reviews complete. Remove label when confirmed in prod. 3. Dev/PM/SME reviews complete SMEs have reviewed and approved. and removed 1. Dev/PM/SME Needs a review by a Dev/PM/SME do not merge Do not merge until this label is removed labels Jul 6, 2026
@justinegeffen justinegeffen merged commit eacd9c8 into master Jul 7, 2026
10 checks passed
@justinegeffen justinegeffen deleted the MichaelTansiniSeqera-patch-1 branch July 7, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. Edu reviews complete Reviews complete. Remove label when confirmed in prod. 3. Dev/PM/SME reviews complete SMEs have reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants