Skip to content

Preserve queued chat translations during bursts - #86

Merged
sappho192 merged 1 commit into
masterfrom
agent/preserve-chat-translation-queue
Jul 26, 2026
Merged

Preserve queued chat translations during bursts#86
sappho192 merged 1 commit into
masterfrom
agent/preserve-chat-translation-queue

Conversation

@sappho192

Copy link
Copy Markdown
Owner

What changed

  • Removed the policy that cancelled the in-flight chat translation whenever another message was waiting.
  • Kept the existing single-consumer semaphore and bounded FIFO queue so messages are translated in arrival order.
  • Retained MiLMMT's independent 30-second inference timeout and existing queue capacity limits.

Why

A decrypted live log from a short chat burst showed that all 184 messages entered and left the queue, but 13 dequeued messages were discarded by the superseded-translation cancellation path. Four of those translations had already completed before their results were discarded. The maximum queue depth was only 23, with no capacity drops or translation errors.

Impact

During chat bursts, translations may appear later as the FIFO backlog drains, but pending messages no longer cancel and discard earlier translations.

Validation

  • dotnet restore src\IronworksTranslator\IronworksTranslator.sln
  • dotnet build src\IronworksTranslator\IronworksTranslator.sln -c Debug --no-restore — 0 warnings, 0 errors
  • dotnet test tests\IronworksTranslator.Tests\IronworksTranslator.Tests.csproj -c Debug --no-build --no-restore — 174/174 passed
  • git diff --check

@sappho192
sappho192 marked this pull request as ready for review July 26, 2026 13:52
@sappho192
sappho192 merged commit a7eeb53 into master Jul 26, 2026
2 checks passed

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant