Preserve queued chat translations during bursts - #86
Merged
Conversation
sappho192
marked this pull request as ready for review
July 26, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
A decrypted live log from a short chat burst showed that all 184 messages entered and left the queue, but 13 dequeued messages were discarded by the superseded-translation cancellation path. Four of those translations had already completed before their results were discarded. The maximum queue depth was only 23, with no capacity drops or translation errors.
Impact
During chat bursts, translations may appear later as the FIFO backlog drains, but pending messages no longer cancel and discard earlier translations.
Validation
dotnet restore src\IronworksTranslator\IronworksTranslator.slndotnet build src\IronworksTranslator\IronworksTranslator.sln -c Debug --no-restore— 0 warnings, 0 errorsdotnet test tests\IronworksTranslator.Tests\IronworksTranslator.Tests.csproj -c Debug --no-build --no-restore— 174/174 passedgit diff --check