Skip to content

ci: add test-gated GitHub Pages deployment workflow - #4

Merged
samertall merged 1 commit into
mainfrom
ci/pages-workflow-20261110
Nov 10, 2026
Merged

samertall merged 1 commit into
mainfrom
ci/pages-workflow-20261110

Conversation

@samertall

Copy link
Copy Markdown
Owner

Why

The README documents publishing to GitHub Pages through .github/workflows/deploy.yml, but this workflow was missing. GitHub Pages is currently disabled, leaving the otherwise installable front-end MVP without a public demo URL.

What changes

  • On every PR to main: run npm test and npm run build using Node.js 22.
  • On pushes to main (or manual runs on main): build, upload dist/, then deploy the static artifact through the official GitHub Pages Actions.
  • Restrict deployment to the default main branch and grant deployment credentials only to the deploy job.
  • Keep existing local-only data semantics; no backend, analytics, API keys, or external service dependencies are introduced.

Validation

  • GitHub Actions PR check passes (tests + build).
  • Repository owner explicitly authorizes public GitHub Pages publishing.
  • Owner selects Settings → Pages → Source: GitHub Actions.
  • After merge, verify the published site is functional, its routes/assets work, and that it is clearly labeled a front-end MVP.

Publication is intentionally not enabled by creating this PR. This change is ready for review but should not be merged until the owner approves public deployment.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@samertall
samertall marked this pull request as ready for review November 10, 2026 09:36
@coldtea-pr-lens

Copy link
Copy Markdown

Note

The title starts with ci:, so PR Lens left this pull request undrawn. Comment @pr-lens draw to draw it

github.comment.notice: false in .github/pr-lens.yml turns this note off

@samertall
samertall merged commit 2e9d267 into main Nov 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant