Repository navigation
ci: add test-gated GitHub Pages deployment workflow - #4
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
samertall
marked this pull request as ready for review
November 10, 2026 09:36
|
Note The title starts with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The README documents publishing to GitHub Pages through
.github/workflows/deploy.yml, but this workflow was missing. GitHub Pages is currently disabled, leaving the otherwise installable front-end MVP without a public demo URL.What changes
main: runnpm testandnpm run buildusing Node.js 22.main(or manual runs onmain): build, uploaddist/, then deploy the static artifact through the official GitHub Pages Actions.mainbranch and grant deployment credentials only to the deploy job.Validation
Publication is intentionally not enabled by creating this PR. This change is ready for review but should not be merged until the owner approves public deployment.