Replace deprecated asyncio.iscoroutinefunction with inspect.iscoroutinefunction#69581
Merged
Conversation
…nefunction asyncio.iscoroutinefunction() was deprecated in Python 3.12 and is slated for removal in Python 3.16. Replace it with inspect.iscoroutinefunction() in salt/utils/event.py and salt/cluster/consensus/raft/scheduler.py. Add tests that verify no DeprecationWarning is emitted when scheduling coroutine callbacks. Fixes #69580
twangboy
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.iscoroutinefunction()was deprecated in Python 3.12 and is slated for removal in Python 3.16inspect.iscoroutinefunction()insalt/utils/event.pyandsalt/cluster/consensus/raft/scheduler.pyDeprecationWarningis emitted when scheduling coroutine callbacksFixes #69580
Test plan
pytest tests/pytests/unit/cluster/consensus/test_raft_scheduler.py— 16 tests pass including newtest_async_scheduler_no_deprecation_warning_for_coroutine_callbackpytest tests/pytests/unit/utils/event/test_salt_event_schedule.py— 2 new tests pass