Skip to content

Fix permissions on sources and keys #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sir-ragna wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix permissions on sources and keys #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa69973
fix(permissions): permissions on sources and key
sir-ragna Jul 22, 2026
95966d4
feat(mode): add an option to configure sources.list permissions
sir-ragna Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apt/map.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
'periodic_config': '10periodic',
'sources_list_dir': '/etc/apt/sources.list.d',
'remove_sources_list': false,
'mode_sources_list': '0644',
'clean_sources_list_d': false,
'preferences_dir': '/etc/apt/preferences.d',
'preferences': {},
Expand Down Expand Up @@ -53,6 +54,7 @@
'periodic_config': '10periodic',
'sources_list_dir': '/etc/apt/sources.list.d',
'remove_sources_list': false,
'mode_sources_list': '0644',
'clean_sources_list_d': false,
'preferences_dir': '/etc/apt/preferences.d',
'preferences': {},
Expand Down
24 changes: 24 additions & 0 deletions apt/repositories.sls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
{% set clean_keyrings_d = apt.get('clean_keyrings_d', apt_map.clean_keyrings_d) %}
{% set default_url = apt.get('default_url', apt_map.default_url) %}
{% set keyring_package = apt.get('keyring_package', apt_map.default_keyring_package) %}
{% set mode_sources_list = apt.get('mode_sources_list', apt_map.mode_sources_list ) %}

{{ keyring_package }}:
pkg.installed:
Expand Down Expand Up @@ -55,6 +56,8 @@
- group: root
- clean: {{ clean_keyrings_d }}

{% set signedby_files = [] %}

{% for repo, args in repositories.items() %}

{% set r_opts = '' %}
Expand All @@ -81,6 +84,7 @@
{%- set r_distro = args.distro or 'stable' %}
{%- set r_comps = args.comps|default(['main'])|join(' ') %}
{%- set r_keyserver = args.keyserver if args.keyserver is defined else apt_map.default_keyserver %}
{%- set r_signedby_file = r_opts.split() | select ('match', '^signed-by=') | map('replace', 'signed-by=', '') | first | default(none) %}

{%- for type in args.type|d(['binary']) %}
{%- set r_type = 'deb-src' if type == 'source' else 'deb' %}
Expand Down Expand Up @@ -114,11 +118,31 @@
file.managed:
- name: {{ sources_list_dir }}/{{ r_file }}
- replace: false
- mode: {{ mode_sources_list }}
- user: root
- group: root
- require_in:
- file: {{ sources_list_dir }}
# require_in the directory clean state
# This way, we don't remove all the files, just to add them again.
{%- endfor %}

{% if r_signedby_file %}
{% do signedby_files.append(r_signedby_file) %}
{%- endif %}
{% endfor %}

{% for signedby_file in signedby_files | unique %}
{{ signedby_file }}:
file.managed:
- name: {{ signedby_file }}
- replace: false
- mode: '0644'
# The above permissions are not configurable because 'apt' drops privileges
# when doing key verification, even when running as root it is important
# that these keys are readable for everyone.
- user: root
- group: root
{% endfor %}

{% if repositories %}
Expand Down
1 change: 1 addition & 0 deletions pillar.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ apt:

remove_sources_list: true
clean_sources_list_d: true
mode_sources_list: '0644'

remove_preferences: true
clean_preferences_d: true
Expand Down