Repository navigation
fix(combobox): preserve application-ranked search matches - #171
Draft
DominusKelvin wants to merge 2 commits into
Draft
DominusKelvin wants to merge 2 commits into
DominusKelvin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application-owned search can return semantic matches such as “Automobile” for “car”. Combobox previously applied its own substring filter again and hid those useful results.
Add Boolean
filter(defaulttrue) to Vue, React and Svelte.filter={false}displays application-supplied options in their supplied order. Existing local matching remains enabled by default; query/search events, debounce, loading/error, disabled choices, typed values, forms, focus and selection keep their existing contracts. There is no new transport or request API.Includes safe source lineage, application-match stories in all three Storybooks, and automatic all-framework no-DOM SSR regression checks. Canonical docs, source copies, remote usage and a live semantic-match example are provided in a separate docs PR.
Validation: 615 tests, all-framework SSR, lineage/Tailwind/format checks, library and three Storybook builds, packed-CLI smoke. Twelve headless desktop/mobile light/dark framework scenarios pass ranking, live filter changes, disabled choices, typed form values, selection, Escape, Tab, outside dismissal and focus. Four canonical docs browser scenarios pass. Source changes stay isolated from the prepared Flag 0.0.7 release.
Closes #165. This remains a draft; no merge or package publication is requested.