Repository navigation
Conversation
…robenius-pari2191
Reuse Dima Pasechnik’s tests from PR sagemath#234 at 73059bd. Retain only the tests, with comments updated for the upstream PARI fix; do not add the temporary mateigen rounding workaround.
Member
Author
|
@antonio-rojas - 2.2.6 version is tainted on PyPI, so it has to be 2.2.7. Are you OK with it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare cypari2 2.2.7 for PARI 2.19.1 and publish a tested source archive and complete CPython 3.13–3.15 wheel set for Linux and macOS.
The yanked 2.2.6 release contains only two wheels: its uploader stopped on an unsupported macOS 27 wheel tag. Build macOS wheels on macOS 15, following #211, and check the complete artifact set before any upload. Build the sdist once, verify its hash at every consumer, and use its own sources and tests for all wheels and native macOS/Linux ARM source-install tests. Verify that repaired wheels load their bundled PARI library inside the test environment. Use checksum-verified private PARI installations, including on the existing Darwin 27 CI runner, so CI does not replace its Homebrew packages. Retain Homebrew's macOS
-O1workaround for PARI bug #2608 and check expression output/history after startup-file stack resizing. Scope uv build settings to cypari2 so rebuilding cysignals does not receive PARI-specific options. Align the development lock with cibuildwheel 4.3.5 and use portable checksum verification on Alpine.Use GNU C17 for PARI's POSIX headers: strict C17 hides
sigjmp_bufon glibc, causing the PARI version probe to fail with 2.19.1. Keep an optional compiler-standard override for validating older, unchanged source refs.Include #214 through its original author commit:
idealfrobeniusmust copy a borrowed result before wrapping it when Galois data lives on the heap. Both API entry points reproduce the error on unchanged 2.2.6 with PARI 2.19.1 and pass after the fix. Add the nine precision tests from #234 without its temporary rounding workaround, since PARI 2.19.1 resolves the underlying pivot failure. Run the complete test target for source installs and repaired wheels.Validation so far: on macOS ARM, unchanged 2.2.6 passes 2,496 doctests and six unit tests for Python 3.13, 3.14 and 3.15. The 2.2.7 candidate with the ownership fix passes 2,496 doctests and 16 unit tests on all three Python versions. Actual loaded libraries were checked against the unpatched private PARI 2.19.1 build. The previous full matrix also passed all six native macOS/Linux ARM source installations and all 18 wheels (CPython 3.13–3.15, macOS ARM/Intel, manylinux/musllinux ARM/x86_64), including bundled-library checks and strict distribution validation. A fresh private PARI 2.17.1 build verifies compatibility with Sage's classic dependency version. The final commit must pass fresh normal CI and distribution checks before tagging or publication.