Repository navigation
Move the VirusTotal scan to release-policy a601f1d - #208
Merged
Merged
Conversation
The 1aa75b4 upload step fails without reporting why. a601f1d checks the key's shape and prints VirusTotal's response when an upload is refused, and matches the pin the other consumers use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the VirusTotal release scan to release-policy
a601f1d, the pin the other consumers use.mainstill calls1aa75b4, whose upload step fails without saying why; the dispatch on 12 October (run 38243851242) failed that way.Between the two pins the reusable workflow changes only its upload step (release-policy #163): it checks that
VT_API_KEYis 64 lower-case hex characters and prints VirusTotal's response when an upload is refused. Its inputs and secrets are unchanged.Evidence
mainfailed in the upload step. Runs 38244091786 and 38244215064 from the test branch also failed; run 38244615971 on the same branch then passed both jobs.actionlint .github/workflows/virustotal.ymlexits 0.a601f1dis reachable from release-policymain, andvirustotal-release.ymlhas not changed there since.Merge danger
Door: two-way. Blast radius: release scans
Only the VirusTotal workflow changes. It runs when a release is published or dispatched.
Unverified
The scan has not run at the new pin. After merge, a dispatch for
v3.4.2onmainwill confirm it. Why the test branch began passing is not established from the logs; a correctedVT_API_KEYsecret would explain it.