Skip to content

Prevent Todo shortcuts from firing during shortcut recording#1792

Open
culpen90 wants to merge 1 commit into
rxhanson:mainfrom
culpen90:fix/suspend-todo-shortcuts-during-recording
Open

Prevent Todo shortcuts from firing during shortcut recording#1792
culpen90 wants to merge 1 commit into
rxhanson:mainfrom
culpen90:fix/suspend-todo-shortcuts-during-recording

Conversation

@culpen90

Copy link
Copy Markdown
Contributor

Summary

  • Suspend Toggle Todo and Reflow Todo bindings while a shortcut field is recording.
  • Prevent Todo settings changes from restoring those bindings during recording.
  • Restore only bindings allowed by the current Todo and Todo Mode state.
  • Add regression coverage for suspension and state-aware restoration.

Context

Window-action bindings are already suspended during shortcut recording. Todo shortcuts use separate MASShortcut registrations, so they could remain active and trigger Rectangle behavior while a new shortcut was being entered.

Testing

  • Focused shortcut-recording suite: 6 tests passed.
  • Full suite comparison: this branch and a clean checkout of current upstream main report the same 21 unrelated cooperative-resize assertion failures. The branch adds three passing tests, for 173 total tests versus 170 on the upstream baseline.

Fixes #195

@culpen90
culpen90 marked this pull request as ready for review July 18, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When setting keyboard shortcuts, existing Rectangle shortcuts continue to have effect

1 participant