Suggest explicit bool ops for unnecessary_fold - #17801
Draft
beriktassuly wants to merge 1 commit into
Draft
beriktassuly wants to merge 1 commit into
beriktassuly wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request, and welcome! You should hear from one of our reviewers after this PR gets at least 2 reviews from the community. Please see the contribution instructions for more information. |
rustbot
added
the
S-waiting-on-review
beriktassuly
force-pushed
the
unnecessary-fold-bool-ops
branch
from
September 27, 2026 16:07
9c76400 to
d1a6159
Compare
beriktassuly
force-pushed
the
unnecessary-fold-bool-ops
branch
from
September 27, 2026 16:19
d1a6159 to
53ddfa3
Compare
CommanderStorm
suggested changes
Sep 27, 2026
Contributor
There was a problem hiding this comment.
Community review:
Why is there all of this stuff added.. Can you please comment why you added this inline?
The conclusion on the issue was that adding an diagnostic and marking this as MaybeIncorrect is a good solution.
Also, given that you have included how you tested things in your description (plus changes seem not quite related)..
Please read our LLM usage policy and see if you followed it.
Author
|
hmm yep, you're right I need to check all properly. I will make it a draft for now |
beriktassuly
marked this pull request as draft
September 28, 2026 10:08
rustbot
removed
the
S-waiting-on-review
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17792.
This changes bool unnecessary_fold diagnostics to suggest an explicit non-short-circuiting | or & fold when the current closure uses || or &&, while still noting any/all for cases where short-circuiting is intended.
changelog: [
unnecessary_fold]: Suggest explicit non-short-circuiting bool ops for boolean folds that use||or&&.Tested with:
TESTNAME=unnecessary_fold cargo uitest