Repository navigation
Add possibility to add the team list for close and postpone commands - #366
Conversation
|
There is no CI? O.o |
| ], | ||
| justification!(), | ||
| RfcBotCommand::FcpPropose(FcpDispositionData::Close(Some( | ||
| ["T-avengers", "justice-league"].iter().copied().collect() |
There was a problem hiding this comment.
I'm not sure what the point of actually storing these is. There's nothing useful we can do with teams for close or postpone. I don't really mind accepting teams and treating it as a no-op, but I think we should drop that information as soon as possible (i.e., during parsing).
There was a problem hiding this comment.
They're used in the same way as for merge, so I don't really understand your comment.
There was a problem hiding this comment.
Adding more context: in the mdbook repository, I don't want to add the T-mdbook on each issue/PR where I want to start an FCP. When it's fcp merge, I can add mdbook and it'll work. But fcp close mdbook doesn't work. What this PR does is allowing the mdbook team to use fcp close mdbook command so we don't have to add the T-mdbook label.
There was a problem hiding this comment.
I think I was thinking of something else (cancel?) when I said that, sorry. This seems fine.
It happened a few times in the mdbook repository that I tried to use
fcp close mdbookwhich failed because theclosecommand doesn't support it. So while I was at it, I added it forpostponetoo.