Reorder and relabel transfer action buttons to Undo (5560)#5604
Open
augustocbx wants to merge 1 commit into
Open
Reorder and relabel transfer action buttons to Undo (5560)#5604augustocbx wants to merge 1 commit into
augustocbx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5560
Description
On the Inventory Transfers index, the action buttons were in a different order than the rest of the system and the destructive action was labeled "Delete", even though it actually reverses (undoes) the transfer and restores the original inventory counts.
This change brings the transfers row in line with the rest of the app and the issue's acceptance criteria:
undoicon.Only the view partial changed; the underlying
destroy/TransferDestroyServicebehavior is untouched.Type of change
How Has This Been Tested?
spec/requests/transfers_request_spec.rb(written first, watched fail, now passing):fa-undoicon and no longer usesfa-trashspec/system/transfer_system_spec.rbthat clicked the "Delete" button to click "Undo".Commands run:
Screenshots
Before

After
