Return only the key from interpolation_keys for sprintf-style patterns - #752
Open
lenamonj wants to merge 1 commit into
Open
Return only the key from interpolation_keys for sprintf-style patterns#752lenamonj wants to merge 1 commit into
lenamonj wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I18n.interpolation_keysreturned the sprintf format specifier alongside the key for the%<name>fmtform:Regexp.unionof the interpolation patterns has two capture groups for that pattern, andscanreturns every group.interpolate_hashalready picks the first non-nil capture as the key;interpolation_keys_from_translationnow does the same, so the example returns["count", "v"].Four tests added.
bundle exec rakepasses on Ruby 3.3.8, 1611 runs (1607 before).