Skip to content

Preserve false entries in KeyValue subtree proxies - #748

Open
OskarEichler wants to merge 1 commit into
ruby-i18n:masterfrom
OskarEichler:codex/key-value-false
Open

Preserve false entries in KeyValue subtree proxies#748
OskarEichler wants to merge 1 commit into
ruby-i18n:masterfrom
OskarEichler:codex/key-value-false

Conversation

@OskarEichler

Copy link
Copy Markdown

Summary

Use key ownership rather than truthiness when reading cached KeyValue subtree entries.

The current proxy re-reads cached false values and reports them as absent through has_key?. Explicit key checks preserve boolean translations and avoid repeated store reads.

Verification

  • focused external false-value ownership/cache model
  • 1,607 base-suite runs / 2,674 assertions
  • 1,888 Rails-suite runs / 3,020 assertions
  • all 46 shipped Ruby files pass syntax checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant