Return an empty translation tree for empty KeyValue stores - #747
Closed
OskarEichler wants to merge 1 commit into
Closed
Return an empty translation tree for empty KeyValue stores#747OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
Collaborator
|
But why? |
Author
|
This came from the broad dependency audit rather than a concrete application failure. The narrow rationale was to make an empty store conform to the translation-tree shape, but I do not have a real consumer bug or use case that justifies changing behavior. I am closing it rather than asking the project to carry a speculative change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seed the KeyValue translation reduction with an empty hash.
Without an initial value, an empty store produces
nilinstead of the backend translation-tree contract's empty hash.Verification