Skip to content

Return an empty translation tree for empty KeyValue stores - #747

Closed
OskarEichler wants to merge 1 commit into
ruby-i18n:masterfrom
OskarEichler:codex/key-value-empty
Closed

Return an empty translation tree for empty KeyValue stores#747
OskarEichler wants to merge 1 commit into
ruby-i18n:masterfrom
OskarEichler:codex/key-value-empty

Conversation

@OskarEichler

Copy link
Copy Markdown

Summary

Seed the KeyValue translation reduction with an empty hash.

Without an initial value, an empty store produces nil instead of the backend translation-tree contract's empty hash.

Verification

  • focused external empty-store model
  • 1,607 base-suite runs / 2,674 assertions
  • 1,888 Rails-suite runs / 3,020 assertions
  • all 46 shipped Ruby files pass syntax checks

@radar

radar commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

But why?

@OskarEichler

Copy link
Copy Markdown
Author

This came from the broad dependency audit rather than a concrete application failure. The narrow rationale was to make an empty store conform to the translation-tree shape, but I do not have a real consumer bug or use case that justifies changing behavior. I am closing it rather than asking the project to carry a speculative change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants