Escape custom keys in reserved interpolation regexp - #744
Closed
OskarEichler wants to merge 1 commit into
Closed
Conversation
|
But why? |
Author
|
This came from the broad dependency audit rather than a concrete application failure. Regex metacharacters are technically accepted by reserve_key and can alter matching, but I do not have a real-world reserved key that triggers this. I am closing the speculative change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Escape each reserved interpolation key before composing the cached regular expression.
Custom keys registered with
I18n.reserve_keyare arbitrary symbols. Treating regex metacharacters in those names as syntax can make unrelated placeholders look reserved.Verification