Skip to content

Move the headers from .h to .hpp#250

Open
saikishor wants to merge 11 commits into
ros:rollingfrom
saikishor:update/headers_to_hpp
Open

Move the headers from .h to .hpp#250
saikishor wants to merge 11 commits into
ros:rollingfrom
saikishor:update/headers_to_hpp

Conversation

@saikishor

@saikishor saikishor commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

As per the discussion over #230 (comment), I've moved the headers from .h to .hpp

@saikishor saikishor force-pushed the update/headers_to_hpp branch from c9899fc to c544628 Compare April 6, 2026 18:36
@saikishor

saikishor commented Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

Even though it appears as if I haven't moved the file, I think it is a github artifact, but the original file does retain the git history

image image

ahcorde
ahcorde requested changes Apr 7, 2026
View reviewed changes
Comment thread urdf_parser/include/urdf_parser/exportdecl.h Outdated
Comment thread urdf_parser/include/urdf_parser/exportdecl.hpp Outdated
@saikishor saikishor force-pushed the update/headers_to_hpp branch 2 times, most recently from 517d7ca to d6fd969 Compare April 7, 2026 10:48
ahcorde
ahcorde requested changes Apr 7, 2026
View reviewed changes
Comment thread urdf_parser/include/urdf_parser/exportdecl.h Outdated
@saikishor saikishor force-pushed the update/headers_to_hpp branch from a28b4eb to 9c457ad Compare April 7, 2026 11:02
ahcorde
ahcorde requested changes Apr 7, 2026
View reviewed changes

@ahcorde ahcorde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind to fix the conflicts?

saikishor and others added 8 commits April 7, 2026 21:58
@saikishor
move urdf_parser.h to urdf_parser.hpp
5fb3672 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor
move exportdecl.h to exportdecl.hpp
339e4da 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor
Add urdf_parser.h wrapper header pointing to .hpp
440c88d 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor
Add exportdecl.h wrapper header pointing to .hpp
baef56b 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor
Update the license and change the includes to new .hpp
8c71ada 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor @ahcorde
Update urdf_parser/include/urdf_parser/exportdecl.hpp
6abf8a3 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor
Update preprocessors
143d716 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor @ahcorde
Update urdf_parser/include/urdf_parser/exportdecl.h
4acac84 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor saikishor force-pushed the update/headers_to_hpp branch from 9c457ad to 4acac84 Compare April 7, 2026 19:58
@saikishor

saikishor commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

do you mind to fix the conflicts?

Done!

@saikishor saikishor requested a review from ahcorde April 7, 2026 19:58
@saikishor

saikishor commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

@ahcorde Should I add deprecation warnings here as well?

@ahcorde

ahcorde commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

@ahcorde Should I add deprecation warnings here as well?

yes, please

@saikishor
Add deprecation notices
f835425 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@ahcorde

ahcorde commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Pulls: #250, ros/urdfdom_headers#100
Gist: https://gist.githubusercontent.com/ahcorde/611f4084b55e4ff274ccd7e0d732b66d/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos
BUILD args: --packages-above-and-dependencies urdfdom_headers urdfdom
TEST args: --packages-above urdfdom_headers urdfdom
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18905

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Apr 9, 2026
Open
saikishor
saikishor commented Apr 9, 2026
View reviewed changes

@saikishor saikishor left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde I think I made a mistake in the deprecation warnings.

Comment thread urdf_parser/include/urdf_parser/exportdecl.h Outdated
Comment thread urdf_parser/include/urdf_parser/urdf_parser.h Outdated
@ahcorde

ahcorde commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

@ahcorde I think I made a mistake in the deprecation warnings.

yes, can you fix it ?

@saikishor
Fix typos
283e1b4 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor saikishor requested a review from ahcorde April 16, 2026 09:16
@ahcorde

ahcorde commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Pulls: #250, ros/urdfdom_headers#100
Gist: https://gist.githubusercontent.com/ahcorde/f729e1d69297fe6c7e76fa4d420b5c7a/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos
BUILD args: --packages-above-and-dependencies urdfdom_headers urdfdom
TEST args: --packages-above urdfdom_headers urdfdom
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18986

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

scpeters
scpeters reviewed Apr 17, 2026
View reviewed changes
Comment thread urdf_parser/include/urdf_parser/urdf_parser.hpp Outdated
@saikishor
Use updated headers from urdfdom_headers
49d5b20 
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@saikishor saikishor requested a review from scpeters April 20, 2026 21:16
@ahcorde

ahcorde commented May 6, 2026

Copy link
Copy Markdown
Contributor

Pulls: #250, ros/urdfdom_headers#100
Gist: https://gist.githubusercontent.com/ahcorde/7807971c80e701e4948f0fb0ed97c2b7/raw/5219abd04cbab827d14e82f2a4404462b5425fe8/ros2.repos
BUILD args: --packages-above-and-dependencies urdf_parser urdfdom_headers
TEST args: --packages-above urdf_parser urdfdom_headers
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19163

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@mergify

mergify Bot commented Jun 21, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde
@scpeters scpeters Awaiting requested review from scpeters

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saikishor @ahcorde @scpeters