[win] Fix testRooFitHS3 linker error on Windows#22760
Merged
Merged
Conversation
Fix the following linker error on Windows: testRooFitHS3.obj : error LNK2001: unresolved external symbol "public: static bool RooJSONFactoryWSTool::importNoDomainParametersAsRooConstVars" (?importNoDomainParametersAsRooConstVars@RooJSONFactoryWSTool@@2_NA)
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 3240fd8. ♻️ This comment has been updated with latest results. |
guitargeek
added
in:RooFit
pr:emergency🚨
This avoids bolerplate code with getters and setters for each static configuration variable.
guitargeek
force-pushed
the
fix-testRooFitHS3
branch
from
b3492e9 to
3240fd8
Compare
guitargeek
approved these changes
Jul 7, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
Thanks for spotting this problem! I refactored the fix to require less boilerplate code, and now this is good to go.
Contributor
|
Compile step on Windows succeeded, which was the success criterion for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following linker error on Windows:
testRooFitHS3.obj : error LNK2001: unresolved external symbol "public: static bool RooJSONFactoryWSTool::importNoDomainParametersAsRooConstVars" (?importNoDomainParametersAsRooConstVars@RooJSONFactoryWSTool@@2_NA)