Skip to content

Gloas fix submit balances - #1161

Open
0xfornax wants to merge 3 commits into
masterfrom
gloas-fix-submit-balances
Open

Gloas fix submit balances#1161
0xfornax wants to merge 3 commits into
masterfrom
gloas-fix-submit-balances

Conversation

@0xfornax

@0xfornax 0xfornax commented Aug 7, 2026

Copy link
Copy Markdown
Member

This branch fixes network balance submission after Gloas by introducing a fork-aware WithdrawalFinder that locates validator withdrawals on the EL once beacon blocks no longer carry execution payloads. It routes pre-Gloas searches through the existing beacon path, and continues on the EL when a search crosses the fork boundary. It also improves megapool notify-final-balance CLI.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Coverage Report

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/megapool 0.11% (-0.01%) 👎
github.com/rocket-pool/smartnode/rocketpool/api/megapool 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool/watchtower 0.69% (-0.00%) 👎
github.com/rocket-pool/smartnode/shared/services 0.16% (-0.00%) 👎
github.com/rocket-pool/smartnode/shared/services/beacon 11.03% (-0.36%) 👎
github.com/rocket-pool/smartnode/shared/services/beacon/client 0.35% (-0.00%) 👎
github.com/rocket-pool/smartnode/shared/types/api 5.27% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/megapool/notify-final-balance.go 0.00% (ø) 2480 (+1183) 0 2480 (+1183)
github.com/rocket-pool/smartnode/rocketpool/api/megapool/status.go 0.00% (ø) 2665 (+21) 0 2665 (+21)
github.com/rocket-pool/smartnode/rocketpool/watchtower/submit-network-balances.go 4.43% (-0.05%) 6459 (+76) 286 6173 (+76) 👎
github.com/rocket-pool/smartnode/shared/services/beacon/client/std-http-client.go 0.00% (ø) 10036 (+60) 0 10036 (+60)
github.com/rocket-pool/smartnode/shared/services/beacon/client/types.go 3.45% (ø) 348 12 336
github.com/rocket-pool/smartnode/shared/services/beacon/config.go 10.95% (-0.68%) 822 (+48) 90 732 (+48) 👎
github.com/rocket-pool/smartnode/shared/services/megapools.go 0.43% (-0.01%) 12104 (+290) 52 12052 (+290) 👎
github.com/rocket-pool/smartnode/shared/types/api/megapool.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/rocket-pool/smartnode/rocketpool/watchtower/submit-network-balances-state_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant