Driver not working on kernel 6.10.6-200.fc40.x86_64

[Bandito11]

DKMS make.log for applespi-0.1 for kernel 6.10.6-200.fc40.x86_64 (x86_64)
Wed Aug 28 02:38:45 AM EDT 2024
make -C /lib/modules/6.10.6-200.fc40.x86_64/build M=/var/lib/dkms/applespi/0.1/build modules
make[1]: Entering directory '/usr/src/kernels/6.10.6-200.fc40.x86_64'
CC [M] /var/lib/dkms/applespi/0.1/build/apple-ibridge.o
CC [M] /var/lib/dkms/applespi/0.1/build/apple-ib-tb.o
CC [M] /var/lib/dkms/applespi/0.1/build/apple-ib-als.o
/var/lib/dkms/applespi/0.1/build/apple-ib-tb.c: In function ‘appletb_fill_report_info’:
/var/lib/dkms/applespi/0.1/build/apple-ib-tb.c:949:9: warning: enumeration value ‘HID_REPORT_TYPES’ not handled in switch [-Wswitch]
949 | switch (field->report->type) {
| ^~~~~~
/var/lib/dkms/applespi/0.1/build/apple-ibridge.c:192:6: warning: no previous prototype for ‘appleib_detach_and_free_hid_driver’ [-Wmissing-prototypes]
192 | void appleib_detach_and_free_hid_driver(struct appleib_device *ib_dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/applespi/0.1/build/apple-ibridge.c:901:10: error: ‘struct acpi_driver’ has no member named ‘owner’
901 | .owner = THIS_MODULE,
| ^~~~~
In file included from ./arch/x86/include/asm/mem_encrypt.h:15,
from ./include/linux/mem_encrypt.h:17,
from ./arch/x86/include/asm/processor-flags.h:6,
from ./arch/x86/include/asm/irqflags.h:5,
from ./include/linux/irqflags.h:18,
from ./include/linux/spinlock.h:59,
from ./include/linux/mmzone.h:8,
from ./include/linux/gfp.h:7,
from ./include/linux/slab.h:16,
from ./include/linux/resource_ext.h:11,
from ./include/linux/acpi.h:13,
from /var/lib/dkms/applespi/0.1/build/apple-ibridge.c:45:
./include/linux/init.h:180:21: error: initialization of ‘const struct acpi_device_id *’ from incompatible pointer type ‘struct module *’ [-Wincompatible-pointer-types]
180 | #define THIS_MODULE (&__this_module)
| ^
/var/lib/dkms/applespi/0.1/build/apple-ibridge.c:901:27: note: in expansion of macro ‘THIS_MODULE’
901 | .owner = THIS_MODULE,
| ^~~~~~~~~~~
./include/linux/init.h:180:21: note: (near initialization for ‘appleib_driver.ids’)
180 | #define THIS_MODULE (&__this_module)
| ^
/var/lib/dkms/applespi/0.1/build/apple-ibridge.c:901:27: note: in expansion of macro ‘THIS_MODULE’
901 | .owner = THIS_MODULE,
| ^~~~~~~~~~~
make[3]: *** [scripts/Makefile.build:244: /var/lib/dkms/applespi/0.1/build/apple-ibridge.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/usr/src/kernels/6.10.6-200.fc40.x86_64/Makefile:1946: /var/lib/dkms/applespi/0.1/build] Error 2
make[1]: *** [Makefile:252: __sub-make] Error 2
make[1]: Leaving directory '/usr/src/kernels/6.10.6-200.fc40.x86_64'
make: *** [Makefile:22: all] Error 2

Here is the log file. Please help :(

Thanks!

Edit:

I tried almas, ecos-hj and BrianValente branches but neither of their fixes worked for me.

[RamtinKosari]

i have same problem this driver is not working on kernel 6 version

[Ethelnol]

i downloaded and used the almas version for linux kernel 6.1.0-25 and was able to get it to compile after changing 2 lines of code that errored
i solved apple-ib-tb.c:949 by adding default: break; on line 956-957 after case HID_FEATURE_REPORT: report_info->report_type = 3; break; on 954-955
i was only given one other error apple-ibridge.c:905 which i fixed by changing void in static void appleib_remove(struct acpi_device *acpi) on 846 to int and return; on 852 to return 1;

after compilation and reboot, i needed to run sudo echo '1-3' > /sys/bus/usb/drivers/usb/unbind && sudo echo '1-3' > /sys/bus/usb/drivers/usb/bind to get the touchbar to work as recommended here https://github.com/roadrunner2/macbook12-spi-driver/issues/42#issuecomment-602160740

[miguelqvd]

Is this repository being regularly merged to linux kernel?

[arag0re]

Hey, I got the driver running on my Ubuntu 24.04 install on a mbp13,2 on kernel 6.8 for a while, with the patches from this issue aswell as the macbook-quirks.service from issue #42. Recently I upgraded to kernel 6.11 and I cant get the driver to work anymore. I fixed some more compile errors, but even after that the touchbar wont turn on anymore. Will upload my fixes and dmesg logs later, maybe someone can help 🍻

[miguelqvd]

Thank you for your efforts. I'm trying to bring a MacBook 8,1 back to life. That model had a very bad reputation due to over heating. Surprisedly, one can get a marvelous user experience with that machine and ubuntu. It works really fast and fluid and no overheating at all. Sadly, suspension mode, keyboard+touchpad, bluetooth and audio (only jack output is working) are preventing me from making a daily use of that machine.

[jussike]

Please check my fork https://github.com/jussike/macbook12-spi-driver/commits/touchbar-driver-hid-driver/

It can be compiled against newer kernel, 6.8 at least.
You'll not need to compile applespi at all because it's already merged to mainline. It's removed on my fork.

[exorsize]

Please check my fork https://github.com/jussike/macbook12-spi-driver/commits/touchbar-driver-hid-driver/

It can be compiled against newer kernel, 6.8 at least. You'll not need to compile applespi at all because it's already merged to mainline. It's removed on my fork.

fails to compile on arch, kernel 6.13.7, mbp 14,3.
please advice

DKMS (dkms-3.1.6) make.log for applespi/0.1 for kernel 6.13.7-arch1-1 (x86_64)
Wed Mar 19 03:06:07 CET 2025

Cleaning build area
# command: make clean
make -C /lib/modules/6.13.7-arch1-1/build M=/var/lib/dkms/applespi/0.1/build clean
make[1]: Entering directory '/usr/lib/modules/6.13.7-arch1-1/build'
make[2]: Entering directory '/var/lib/dkms/applespi/0.1/build'
make[2]: Leaving directory '/var/lib/dkms/applespi/0.1/build'
make[1]: Leaving directory '/usr/lib/modules/6.13.7-arch1-1/build'

# exit code: 0
# elapsed time: 00:00:00
----------------------------------------------------------------

Building module(s)
# command: make -j8 KERNELRELEASE=6.13.7-arch1-1
make -C /lib/modules/6.13.7-arch1-1/build M=/var/lib/dkms/applespi/0.1/build modules
make[1]: Entering directory '/usr/lib/modules/6.13.7-arch1-1/build'
make[2]: Entering directory '/var/lib/dkms/applespi/0.1/build'
  CC [M]  apple-ibridge.o
  CC [M]  apple-ib-tb.o
  CC [M]  apple-ib-als.o
apple-ib-als.c:679:19: error: initialization of ‘void (*)(struct platform_device *)’ from incompatible pointer type ‘int (*)(struct platform_device *)’ [-Wincompatible-pointer-types]
  679 |         .remove = appleals_platform_remove,
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~
apple-ib-als.c:679:19: note: (near initialization for ‘appleals_platform_driver.remove’)
apple-ib-tb.c:1295:19: error: initialization of ‘void (*)(struct platform_device *)’ from incompatible pointer type ‘int (*)(struct platform_device *)’ [-Wincompatible-pointer-types]
 1295 |         .remove = appletb_platform_remove,
      |                   ^~~~~~~~~~~~~~~~~~~~~~~
apple-ib-tb.c:1295:19: note: (near initialization for ‘appletb_platform_driver.remove’)
make[4]: *** [/usr/lib/modules/6.13.7-arch1-1/build/scripts/Makefile.build:196: apple-ib-als.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: *** [/usr/lib/modules/6.13.7-arch1-1/build/scripts/Makefile.build:196: apple-ib-tb.o] Error 1
apple-ibridge.c:752:25: error: initialization of ‘const __u8 * (*)(struct hid_device *, __u8 *, unsigned int *)’ {aka ‘const unsigned char * (*)(struct hid_device *, unsigned char *, unsigned int *)’} from incompatible pointer type ‘__u8 * (*)(struct hid_device *, __u8 *, unsigned int *)’ {aka ‘unsigned char * (*)(struct hid_device *, unsigned char *, unsigned int *)’} [-Wincompatible-pointer-types]
  752 |         .report_fixup = appleib_report_fixup,
      |                         ^~~~~~~~~~~~~~~~~~~~
apple-ibridge.c:752:25: note: (near initialization for ‘appleib_hid_driver.report_fixup’)
apple-ibridge.c:901:10: error: ‘struct acpi_driver’ has no member named ‘owner’
  901 |         .owner          = THIS_MODULE,
      |          ^~~~~
In file included from /usr/lib/modules/6.13.7-arch1-1/build/arch/x86/include/asm/mem_encrypt.h:15,
                 from /usr/lib/modules/6.13.7-arch1-1/build/include/linux/mem_encrypt.h:17,
                 from /usr/lib/modules/6.13.7-arch1-1/build/arch/x86/include/asm/processor-flags.h:6,
                 from /usr/lib/modules/6.13.7-arch1-1/build/arch/x86/include/asm/irqflags.h:5,
                 from /usr/lib/modules/6.13.7-arch1-1/build/include/linux/irqflags.h:18,
                 from /usr/lib/modules/6.13.7-arch1-1/build/include/linux/spinlock.h:59,
                 from /usr/lib/modules/6.13.7-arch1-1/build/include/linux/mmzone.h:8,
                 from /usr/lib/modules/6.13.7-arch1-1/build/include/linux/gfp.h:7,
                 from /usr/lib/modules/6.13.7-arch1-1/build/include/linux/slab.h:16,
                 from /usr/lib/modules/6.13.7-arch1-1/build/include/linux/resource_ext.h:11,
                 from /usr/lib/modules/6.13.7-arch1-1/build/include/linux/acpi.h:13,
                 from apple-ibridge.c:45:
/usr/lib/modules/6.13.7-arch1-1/build/include/linux/init.h:180:21: error: initialization of ‘const struct acpi_device_id *’ from incompatible pointer type ‘struct module *’ [-Wincompatible-pointer-types]
  180 | #define THIS_MODULE (&__this_module)
      |                     ^
apple-ibridge.c:901:27: note: in expansion of macro ‘THIS_MODULE’
  901 |         .owner          = THIS_MODULE,
      |                           ^~~~~~~~~~~
/usr/lib/modules/6.13.7-arch1-1/build/include/linux/init.h:180:21: note: (near initialization for ‘appleib_driver.ids’)
  180 | #define THIS_MODULE (&__this_module)
      |                     ^
apple-ibridge.c:901:27: note: in expansion of macro ‘THIS_MODULE’
  901 |         .owner          = THIS_MODULE,
      |                           ^~~~~~~~~~~
make[4]: *** [/usr/lib/modules/6.13.7-arch1-1/build/scripts/Makefile.build:196: apple-ibridge.o] Error 1
make[3]: *** [/usr/lib/modules/6.13.7-arch1-1/build/Makefile:1989: .] Error 2
make[2]: *** [/usr/lib/modules/6.13.7-arch1-1/build/Makefile:251: __sub-make] Error 2
make[2]: Leaving directory '/var/lib/dkms/applespi/0.1/build'
make[1]: *** [Makefile:251: __sub-make] Error 2
make[1]: Leaving directory '/usr/lib/modules/6.13.7-arch1-1/build'
make: *** [Makefile:13: all] Error 2

# exit code: 2
# elapsed time: 00:00:01
----------------------------------------------------------------

[tkalant]

Hello. I have a macbook 8,1, running ubuntu 24.04 with the 6.8 kernel. My keyboard and trackpad sometimes do work upon rebooting, and sometimes do not.
I am trying the touchbar-driver-hid-driver/ branch. I get the same error as I did with the original driver from the main branch. Here is what I see:

root@macbook:~# dkms install -m applespi -v 0.1
Sign command: /usr/bin/kmodsign
Signing key: /var/lib/shim-signed/mok/MOK.priv
Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der
Deprecated feature: REMAKE_INITRD (/var/lib/dkms/applespi/0.1/source/dkms.conf)

Building module:
Cleaning build area...
make -j4 KERNELRELEASE=6.8.0-55-generic....(bad exit status: 2)
ERROR (dkms apport): binary package for applespi: 0.1 not found
Error! Bad return status for module build on kernel: 6.8.0-55-generic (x86_64)
Consult /var/lib/dkms/applespi/0.1/build/make.log for more information.

and here is what the make.log tells me:

DKMS make.log for applespi-0.1 for kernel 6.8.0-55-generic (x86_64)
Do 20. Mär 11:48:56 +0330 2025
make -C /lib/modules/6.8.0-55-generic/build M=/var/lib/dkms/applespi/0.1/build modules
make[1]: Entering directory '/usr/src/linux-headers-6.8.0-55-generic'
warning: the compiler differs from the one used to build the kernel
  The kernel was built by: x86_64-linux-gnu-gcc-13 (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0
  You are using:           gcc-13 (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0
  CC [M]  /var/lib/dkms/applespi/0.1/build/applespi.o
  CC [M]  /var/lib/dkms/applespi/0.1/build/apple-ibridge.o
  CC [M]  /var/lib/dkms/applespi/0.1/build/apple-ib-tb.o
  CC [M]  /var/lib/dkms/applespi/0.1/build/apple-ib-als.o
/var/lib/dkms/applespi/0.1/build/apple-ibridge.c:192:6: warning: no previous prototype for ‘appleib_detach_and_free_hid_driver’ [-Wmissing-proto>
  192 | void appleib_detach_and_free_hid_driver(struct appleib_device *ib_dev,
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/applespi/0.1/build/apple-ib-tb.c: In function ‘appletb_fill_report_info’:
/var/lib/dkms/applespi/0.1/build/apple-ib-tb.c:949:9: warning: enumeration value ‘HID_REPORT_TYPES’ not handled in switch [-Wswitch]
  949 |         switch (field->report->type) {
      |         ^~~~~~
/var/lib/dkms/applespi/0.1/build/apple-ibridge.c:905:35: error: initialization of ‘void (*)(struct acpi_device *)’ from incompatible pointer typ>
  905 |                 .remove         = appleib_remove,
      |                                   ^~~~~~~~~~~~~~
/var/lib/dkms/applespi/0.1/build/apple-ibridge.c:905:35: note: (near initialization for ‘appleib_driver.ops.remove’)
/var/lib/dkms/applespi/0.1/build/apple-ib-als.c: In function ‘appleals_config_iio’:
/var/lib/dkms/applespi/0.1/build/apple-ib-als.c:463:36: warning: passing argument 1 of ‘iio_device_alloc’ makes pointer from integer without a c>
  463 |         iio_dev = iio_device_alloc(sizeof(als_dev));
      |                                    ^~~~~~~~~~~~~~~
      |                                    |
      |                                    long unsigned int
In file included from ./include/linux/iio/buffer.h:10,
                 from /var/lib/dkms/applespi/0.1/build/apple-ib-als.c:32:
./include/linux/iio/iio.h:733:49: note: expected ‘struct device *’ but argument is of type ‘long unsigned int’
  733 | struct iio_dev *iio_device_alloc(struct device *parent, int sizeof_priv);
      |                                  ~~~~~~~~~~~~~~~^~~~~~
/var/lib/dkms/applespi/0.1/build/apple-ib-als.c:463:19: error: too few arguments to function ‘iio_device_alloc’
  463 |         iio_dev = iio_device_alloc(sizeof(als_dev));
      |                   ^~~~~~~~~~~~~~~~
./include/linux/iio/iio.h:733:17: note: declared here
  733 | struct iio_dev *iio_device_alloc(struct device *parent, int sizeof_priv);
      |                 ^~~~~~~~~~~~~~~~
In file included from /var/lib/dkms/applespi/0.1/build/apple-ib-als.c:36:
/var/lib/dkms/applespi/0.1/build/apple-ib-als.c:485:72: error: ‘struct iio_dev’ has no member named ‘id’
  485 |         iio_trig = iio_trigger_alloc("%s-dev%d", iio_dev->name, iio_dev->id);
      |                                                                        ^~
./include/linux/iio/trigger.h:160:61: note: in definition of macro ‘iio_trigger_alloc’
  160 |         __iio_trigger_alloc((parent), THIS_MODULE, (fmt), ##__VA_ARGS__)
      |                                                             ^~~~~~~~~~~
./include/linux/iio/trigger.h:160:29: error: passing argument 1 of ‘__iio_trigger_alloc’ from incompatible pointer type [-Werror=incompatible-po>
  160 |         __iio_trigger_alloc((parent), THIS_MODULE, (fmt), ##__VA_ARGS__)
      |                             ^~~~~~~~
      |                             |
      |                             char *
/var/lib/dkms/applespi/0.1/build/apple-ib-als.c:485:20: note: in expansion of macro ‘iio_trigger_alloc’
  485 |         iio_trig = iio_trigger_alloc("%s-dev%d", iio_dev->name, iio_dev->id);
      |                    ^~~~~~~~~~~~~~~~~
./include/linux/iio/trigger.h:163:56: note: expected ‘struct device *’ but argument is of type ‘char *’
  163 | struct iio_trigger *__iio_trigger_alloc(struct device *parent,
      |                                         ~~~~~~~~~~~~~~~^~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:243: /var/lib/dkms/applespi/0.1/build/apple-ib-als.o] Error 1
make[3]: *** Waiting for unfinished jobs....
/var/lib/dkms/applespi/0.1/build/applespi.c: In function ‘applespi_setup_read_txfrs’:
/var/lib/dkms/applespi/0.1/build/applespi.c:590:13: error: ‘struct spi_transfer’ has no member named ‘delay_usecs’
  590 |         dl_t->delay_usecs = applespi->spi_settings.spi_cs_delay;
      |             ^~
/var/lib/dkms/applespi/0.1/build/applespi.c: In function ‘applespi_setup_write_txfrs’:
/var/lib/dkms/applespi/0.1/build/applespi.c:619:13: error: ‘struct spi_transfer’ has no member named ‘delay_usecs’
  619 |         wt_t->delay_usecs = SPI_RW_CHG_DELAY_US;
      |             ^~
/var/lib/dkms/applespi/0.1/build/applespi.c:622:13: error: ‘struct spi_transfer’ has no member named ‘delay_usecs’
  622 |         dl_t->delay_usecs = applespi->spi_settings.spi_cs_delay;
     |             ^~
/var/lib/dkms/applespi/0.1/build/applespi.c:626:13: error: ‘struct spi_transfer’ has no member named ‘delay_usecs’
  626 |         wr_t->delay_usecs = SPI_RW_CHG_DELAY_US;
      |             ^~
/var/lib/dkms/applespi/0.1/build/applespi.c: In function ‘applespi_get_saved_bl_level’:
/var/lib/dkms/applespi/0.1/build/applespi.c:1794:38: error: invalid application of ‘sizeof’ to incomplete type ‘struct efivar_entry’
 1794 |         efivar_entry = kmalloc(sizeof(*efivar_entry), GFP_KERNEL);
      |                                      ^
In file included from ./include/linux/string.h:292,
                 from ./include/linux/bitmap.h:12,
                 from ./include/linux/cpumask.h:12,
                 from ./arch/x86/include/asm/paravirt.h:21,
                 from ./arch/x86/include/asm/irqflags.h:60,
                 from ./include/linux/irqflags.h:18,
                 from ./include/linux/spinlock.h:59,
                 from ./include/linux/mmzone.h:8,
                 from ./include/linux/gfp.h:7,
                 from ./include/linux/slab.h:16,
                 from ./include/linux/resource_ext.h:11,
                 from ./include/linux/acpi.h:13,
                 from /var/lib/dkms/applespi/0.1/build/applespi.c:44:
/var/lib/dkms/applespi/0.1/build/applespi.c:1798:28: error: invalid use of undefined type ‘struct efivar_entry’
 1798 |         memcpy(efivar_entry->var.VariableName, EFI_BL_LEVEL_NAME,
      |                            ^~
./include/linux/fortify-string.h:596:34: note: in definition of macro ‘__fortify_memcpy_chk’
  596 |         const size_t __p_size = (p_size);                               \
      |                                  ^~~~~~
./include/linux/fortify-string.h:653:17: note: in expansion of macro ‘__struct_size’
  653 |                 __struct_size(p), __struct_size(q),                     \
      |                 ^~~~~~~~~~~~~
/var/lib/dkms/applespi/0.1/build/applespi.c:1798:9: note: in expansion of macro ‘memcpy’
 1798 |         memcpy(efivar_entry->var.VariableName, EFI_BL_LEVEL_NAME,
      |         ^~~~~~
/var/lib/dkms/applespi/0.1/build/applespi.c:1798:28: error: invalid use of undefined type ‘struct efivar_entry’
 1798 |         memcpy(efivar_entry->var.VariableName, EFI_BL_LEVEL_NAME,
     |                            ^~
./include/linux/fortify-string.h:598:40: note: in definition of macro ‘__fortify_memcpy_chk’
  598 |         const size_t __p_size_field = (p_size_field);                   \
      |                                        ^~~~~~~~~~~~
./include/linux/fortify-string.h:654:17: note: in expansion of macro ‘__member_size’
  654 |                 __member_size(p), __member_size(q),                     \
      |                 ^~~~~~~~~~~~~
/var/lib/dkms/applespi/0.1/build/applespi.c:1798:9: note: in expansion of macro ‘memcpy’
 1798 |         memcpy(efivar_entry->var.VariableName, EFI_BL_LEVEL_NAME,
      |         ^~~~~~
/var/lib/dkms/applespi/0.1/build/applespi.c:1798:28: error: invalid use of undefined type ‘struct efivar_entry’
 1798 |         memcpy(efivar_entry->var.VariableName, EFI_BL_LEVEL_NAME,
      |                            ^~
./include/linux/fortify-string.h:607:27: note: in definition of macro ‘__fortify_memcpy_chk’
  607 |         __underlying_##op(p, q, __fortify_size);                        \
      |                           ^
/var/lib/dkms/applespi/0.1/build/applespi.c:1798:9: note: in expansion of macro ‘memcpy’
 1798 |         memcpy(efivar_entry->var.VariableName, EFI_BL_LEVEL_NAME,
      |         ^~~~~~
/var/lib/dkms/applespi/0.1/build/applespi.c:1800:21: error: invalid use of undefined type ‘struct efivar_entry’
 1800 |         efivar_entry->var.VendorGuid = EFI_BL_LEVEL_GUID;
      |                     ^~
/var/lib/dkms/applespi/0.1/build/applespi.c:1803:15: error: implicit declaration of function ‘efivar_entry_get’; did you mean ‘efi_mokvar_entry_>
 1803 |         sts = efivar_entry_get(efivar_entry, NULL, &efi_data_len, &efi_data);
      |               ^~~~~~~~~~~~~~~~
      |               efi_mokvar_entry_next
/var/lib/dkms/applespi/0.1/build/applespi.c: In function ‘applespi_save_bl_level’:
/var/lib/dkms/applespi/0.1/build/applespi.c:1830:15: error: implicit declaration of function ‘efivar_entry_set_safe’ [-Werror=implicit-function->
 1830 |         sts = efivar_entry_set_safe((efi_char16_t *)EFI_BL_LEVEL_NAME, efi_guid,
      |               ^~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/applespi/0.1/build/applespi.c: At top level:
/var/lib/dkms/applespi/0.1/build/applespi.c:2228:27: error: initialization of ‘void (*)(struct spi_device *)’ from incompatible pointer type ‘in>
 2228 |         .remove         = applespi_remove,
      |                           ^~~~~~~~~~~~~~~
/var/lib/dkms/applespi/0.1/build/applespi.c:2228:27: note: (near initialization for ‘applespi_driver.remove’)
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:243: /var/lib/dkms/applespi/0.1/build/applespi.o] Error 1
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:243: /var/lib/dkms/applespi/0.1/build/apple-ibridge.o] Error 1
make[2]: *** [/usr/src/linux-headers-6.8.0-55-generic/Makefile:1925: /var/lib/dkms/applespi/0.1/build] Error 2
make[1]: *** [Makefile:240: __sub-make] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-6.8.0-55-generic'
make: *** [Makefile:16: all] Error 2

Any ideas?

[jussike]

Hello. I have a macbook 8,1, running ubuntu 24.04 with the 6.8 kernel. My keyboard and trackpad sometimes do work upon rebooting, and sometimes do not. I am trying the touchbar-driver-hid-driver/ branch. I get the same error as I did with the original driver from the main branch. Here is what I see:

Any ideas?

Seems that you are using wrong branch or commit.
See the current hash with command
$ git rev-parse --short HEAD
It should give 774b401

[jussike]

Please check my fork https://github.com/jussike/macbook12-spi-driver/commits/touchbar-driver-hid-driver/
It can be compiled against newer kernel, 6.8 at least. You'll not need to compile applespi at all because it's already merged to mainline. It's removed on my fork.

fails to compile on arch, kernel 6.13.7, mbp 14,3. please advice

I have no time to install 6.13 today but I fixed compiling against 6.11
https://github.com/jussike/macbook12-spi-driver/commits/touchbar-driver-hid-driver-linux-6.11

And I made a fix for 6.13 also but I didn't try even to compile it. Please try:
https://github.com/jussike/macbook12-spi-driver/commits/touchbar-driver-hid-driver-linux-6.13

[arag0re]

@jussike @tkalant use the patched version from almas https://github.com/almas/macbook12-spi-driver
in combination with the macbook-quircks.service from issue #42. worked for me on 6.8

[arag0re]

sadly maintianer is afk and wont merge changes into the repo so u need to find the patched forks for yourself

[tkalant]

Seems that you are using wrong branch or commit.
See the current hash with command
$ git rev-parse --short HEAD
It should give 774b401

Hello @jussike Thank you for responding. You were right. I cloned the correct repository, ran the installation, and it seems like it went without a problem, but I keep having the same issue. After rebooting sometimes the keyboard works and sometimes not - here is what I see after installing:

Sign command: /usr/bin/kmodsign
Signing key: /var/lib/shim-signed/mok/MOK.priv
Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der
Deprecated feature: REMAKE_INITRD (/usr/src/applespi-0.1/dkms.conf)
Creating symlink /var/lib/dkms/applespi/0.1/source -> /usr/src/applespi-0.1

Building module:
Cleaning build area...
make -j4 KERNELRELEASE=6.8.0-55-generic....
Signing module /var/lib/dkms/applespi/0.1/build/apple-ibridge.ko
Signing module /var/lib/dkms/applespi/0.1/build/apple-ib-tb.ko
Signing module /var/lib/dkms/applespi/0.1/build/apple-ib-als.ko
Cleaning build area...

apple-ibridge.ko.zst:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.8.0-55-generic/updates/dkms/

apple-ib-tb.ko.zst:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.8.0-55-generic/updates/dkms/

apple-ib-als.ko.zst:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.8.0-55-generic/updates/dkms/
depmod....

I have no time to install 6.13 today but I fixed compiling against 6.11 https://github.com/jussike/macbook12-spi-driver/commits/touchbar-driver-hid-driver-linux-6.11

I also installed kernel 6.11, changed to that kernel on grub when booting, and ran the installation from the 6.11 branch you made yesterday. I made sure I am on the c0cf3bf commit. That did not work, here is what I saw:

Building module:
Cleaning build area...
make -j4 KERNELRELEASE=6.11.0-061100-generic...(bad exit status: 2)
ERROR (dkms apport): binary package for applespi: 0.1 not found
Error! Bad return status for module build on kernel: 6.11.0-061100-generic (x86_64)
Consult /var/lib/dkms/applespi/0.1/build/make.log for more information.

use the patched version from almas https://github.com/almas/macbook12-spi-driver
in combination with the macbook-quircks.service from issue #42. worked for me on 6.8

@arag0re Thank you. I tried this version from almas with 6.8 kernel, it did not work for me. Kept getting the same error as before. And it seems to me (might be wrong) that the macbook-quirks.service is related to the touchbar, which my macbook does not have.

[jussike]

After rebooting sometimes the keyboard works and sometimes not

My fork has no keyboard/touchpad driver bc it's a part of upstream kernel (applespi). Perhaps you should report the upstream driver maintainer. You may use my fork as a touchbar driver if you have any on your device.

Consult /var/lib/dkms/applespi/0.1/build/make.log for more information.

You didn't attach the make.log