Add Zacas support - #662
Merged
Merged
Conversation
Contributor
Author
|
This also solves #659 |
Collaborator
|
The PR was initially failing because our toolchain is too old. That's fixed. But there are still more problems. Some of the test cases are failing. Make sure they pass on Spike before resubmitting. |
Contributor
Author
|
Thanks @aswaterman, I just took the code from the PR but did not check all of the tests. I've updated the failing ones and double checked them with spike. |
Collaborator
|
LGTM now, thanks! |
aswaterman
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR recovers PR #492 which adds tests for the Zacas extension that introduces the following instructions:
The specification is here: https://github.com/riscv/riscv-zacas
The amocas instructions are emitted using a .word directive pending assembler support.