Skip to content

OPFSAdaptiveVFS: load where FileSystemSyncAccessHandle is unavailable #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhashimoto merged 2 commits into from
Oct 13, 2026
Merged

OPFSAdaptiveVFS: load where FileSystemSyncAccessHandle is unavailable #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39e7e1f
Load OPFSAdaptiveVFS where FileSystemSyncAccessHandle is unavailable.
lalexdotcom Oct 3, 2026
80934a5
Add a test that OPFSAdaptiveVFS loads without FileSystemSyncAccessHan…
lalexdotcom Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/examples/OPFSAdaptiveVFS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { WebLocksMixin } from '../WebLocksMixin.js';
const LOCK_NOTIFY_INTERVAL = 1000;

const hasUnsafeAccessHandle =
globalThis.FileSystemSyncAccessHandle.prototype.hasOwnProperty('mode');
globalThis.FileSystemSyncAccessHandle?.prototype.hasOwnProperty('mode');

/**
* @param {string} pathname
Expand Down
13 changes: 13 additions & 0 deletions test/OPFSAdaptiveVFS.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,19 @@ const BUILDS = ['asyncify', 'jspi'];
const supportsJSPI = await TestContext.supportsJSPI();

describe(CONFIG, function() {
it('should load where FileSystemSyncAccessHandle is unavailable', async function() {
// The interface exists in dedicated workers only, so this page lacks it,
// as do Node and a page that is not a secure context.
expect(globalThis.FileSystemSyncAccessHandle).toBeUndefined();
let error;
try {
await import('../src/examples/OPFSAdaptiveVFS.js');
} catch (e) {
error = e;
}
expect(error?.message).toBeUndefined();
});

for (const build of BUILDS) {
if (build === 'jspi' && !supportsJSPI) return;

Expand Down
Loading