Make major-bump labelling resilient so it can't block merges#3
Merged
Conversation
The 'Add label to major bump PR' step ran 'gh pr edit --add-label needs-manual-review'. In any repo lacking that label the step errored, which FAILED the whole Dependabot Auto-Merge job. Because that job is a required check (org ruleset), a major bump then couldn't be merged even after human approval (e.g. realrate/EBA#93). Create the label if missing and guard both label commands with '|| true' so a labelling hiccup can never block a human from merging a reviewed major bump. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the major-bump labelling step in the shared Dependabot Auto-Merge workflow resilient:
needs-manual-reviewlabel if the repo doesn't have it, and|| trueso they can never fail the job.Why
For a major bump the workflow comments + labels the PR for manual review (it does not auto-merge). But the label step ran
gh pr edit --add-label "needs-manual-review", and most repos don't have that label — so the command errored and failed the wholeDependabot Auto-Mergejob.Since that job is a required check (org
dependabot-automergeruleset), the failure blocked the PR from being merged even after a human approved it — the opposite of the intended "leave it for manual review" behaviour. Seen onrealrate/EBA#93(structlog 21.5→26.1.0): comment posted, label step failed, PR stuckBLOCKEDdespite human approval + green tests.Effect
Major bumps now reliably get commented + labelled and remain mergeable by a human after review. Patch/minor behaviour is unchanged.
Part of realrate/RealRate-Private#2148.