Find a way to make Hiccup forms easier to analyze #522

Activity

1. Deraen

   added

   enhancement

   on Dec 22, 2020
2. borkdude commented on Dec 23, 2020

   

   borkdude

   on Dec 23, 2020

   Last edited by borkdude

   More actions

   Alternatives (not necessarily better than what's already mentioned):

   • macro which expands into a vector call:

   (defmacro f [& args] `[~@args])
   (r/f component  1 2 3)

   This solution doesn't need any changes to other code in Reagent, but allows static analysis to detect reagent calls accurately.

   • clj-kondo could have a mode in which it always treats [foo 1 2 3] as a function call in .cljs files. False positives should be handled by users.
3. Kaspazza commented on Nov 5, 2024

   

   Kaspazza

   on Nov 5, 2024

   Last edited by Kaspazza

   More actions

   Form-2 components are marked by clj-kondo as unused binding

   (defn outer 
     [a b c]            ;; <--- those parameters will get marked by clj-kondo as unused-binding
     ;;  ....
     (fn [a b c]        ;; <--- they are repeated here
       [:div
         (str a b c)]))
   
4. borkdude commented on Nov 5, 2024

   

   borkdude

   on Nov 5, 2024

   More actions

   @Kaspazza The way to solve this is to write:

   (defn outer [_a _b _c] ...)
   
5. Kaspazza commented on Nov 5, 2024

   

   Kaspazza

   on Nov 5, 2024

   More actions

   @borkdude Hmmm, I was in a mindset it is used so there should be no warning... But it makes sense... Thanks!
6. reagent-project

   locked and limited conversation to collaborators on Jan 28, 2025
7. Deraen

   converted this issue into a discussion #620 on Jan 28, 2025