Repository navigation
Delete legacy catalyst test helpers (#59283) - #59283
Open
christophpurrer wants to merge 2 commits into
Open
christophpurrer wants to merge 2 commits into
christophpurrer wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126576088. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#59283 Delete the deprecated `createCatalystContextForTest` and `createMockCatalystInstance` helpers from `ReactTestHelper`, now that every caller has migrated to `createTestReactApplicationContext`. Drop the file-level deprecation suppression and its TODO, which only existed for the removed helpers. Changelog: [Internal] Reviewed By: javache Differential Revision: D126576088
christophpurrer
force-pushed
the
export-D126576088
branch
from
October 21, 2026 17:52
fa778f1 to
0a20f77
Compare
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D126576088
branch
from
October 21, 2026 22:27
0a20f77 to
7bf7336
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Delete the deprecated `createCatalystContextForTest` and `createMockCatalystInstance` helpers from `ReactTestHelper`, now that every caller has migrated to `createTestReactApplicationContext`. Drop the file-level deprecation suppression and its TODO, which only existed for the removed helpers. Changelog: [Internal] Reviewed By: javache Differential Revision: D126576088
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#59283 Delete the deprecated `createCatalystContextForTest` and `createMockCatalystInstance` helpers from `ReactTestHelper`, now that every caller has migrated to `createTestReactApplicationContext`. Drop the file-level deprecation suppression and its TODO, which only existed for the removed helpers. Changelog: [Internal] Reviewed By: javache Differential Revision: D126576088
christophpurrer
force-pushed
the
export-D126576088
branch
2 times, most recently
from
October 22, 2026 19:29
f4cec38 to
a7a27f8
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 22, 2026
Summary: Delete the deprecated `createCatalystContextForTest` and `createMockCatalystInstance` helpers from `ReactTestHelper`, now that every caller has migrated to `createTestReactApplicationContext`. Drop the file-level deprecation suppression and its TODO, which only existed for the removed helpers. Changelog: [Internal] Reviewed By: javache Differential Revision: D126576088
Summary: Migrate `ExtraWindowEventListenerTest` from the deprecated `createCatalystContextForTest` helper to `createTestReactApplicationContext`, so the test builds a bridgeless context directly. Stub the feature flags before context creation, since the bridgeless context reads them during init. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D126574365
Summary: Delete the deprecated `createCatalystContextForTest` and `createMockCatalystInstance` helpers from `ReactTestHelper`, now that every caller has migrated to `createTestReactApplicationContext`. Drop the file-level deprecation suppression and its TODO, which only existed for the removed helpers. Changelog: [Internal] Reviewed By: javache Differential Revision: D126576088
christophpurrer
force-pushed
the
export-D126576088
branch
from
October 22, 2026 19:37
a7a27f8 to
d7d1f9c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Delete the deprecated
createCatalystContextForTestandcreateMockCatalystInstancehelpers fromReactTestHelper, now that everycaller has migrated to
createTestReactApplicationContext. Drop thefile-level deprecation suppression and its TODO, which only existed for the
removed helpers.
Changelog:
[Internal]
Reviewed By: javache
Differential Revision: D126576088