Handle EOF in limited ask prompts - #937
Open
JoelTowell wants to merge 2 commits into
Open
JoelTowell wants to merge 2 commits into
JoelTowell wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌈
Problem
ask_simplyalready returnsnilwhen input reaches EOF (here). That behaviour was added in #252, after #248 reported that Ctrl-D raised while handling a plain prompt.ask_filteredusesask_simplyforlimited_toprompts, but passes the result straight intoanswer_match(here). So EOF does not take the same path as an unlimited prompt. The case-sensitive path keeps reasking becausenildoes not match one of the allowed answers. The case-insensitive path raises becauseanswer_matchcallsdowncaseon the answer (here).Closes #935.
Reproduction
The first commit on this branch adds failing examples for this. It can be checked out independently to see the failure.
Solution
Return from
ask_filteredwhenask_simplyreturnsnil, matching the EOF behaviour already used by plain prompts.