Allow required options to be initialised with string keys - #929
Open
JoelTowell wants to merge 3 commits into
Open
JoelTowell wants to merge 3 commits into
JoelTowell wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌈
Problem
Thor supports passing initialised options with either symbol or string keys.
However, when the option is required, the string-key form raises
Thor::RequiredArgumentMissingError.This also affects
invokewhen a required option is declared with a string key and passed with a symbol key, as in #614. I checked that reproduction against this branch and it now passes.Reproduction
The first commit on this branch adds a failing example for this. It can be checked out independently to see the failure.
Solution
Update the required option check in
Thor::Optionsto use a lookup with indifferent access when removing options from@non_assigned_required.